* [PATCH 2/3] ARM: dts: imx6qdl-nitrogen6_som2: fix rv4162 compatible
2017-04-19 20:22 [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible Alexandre Belloni
@ 2017-04-19 20:22 ` Alexandre Belloni
2017-04-20 9:08 ` Gary Bisson
2017-04-19 20:22 ` [PATCH 3/3] ARM: dts: imx7d-nitrogen7: " Alexandre Belloni
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Alexandre Belloni @ 2017-04-19 20:22 UTC (permalink / raw)
To: Shawn Guo, Gary Bisson
Cc: Sascha Hauer, Fabio Estevam, linux-arm-kernel, linux-kernel,
Alexandre Belloni
The rv4162 vendor is microcrystal, not ST.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi
index 559da17297ef..aeaa5a6e4fcf 100644
--- a/arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi
@@ -326,7 +326,7 @@
};
rtc@68 {
- compatible = "st,rv4162";
+ compatible = "microcrystal,rv4162";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_rv4162>;
reg = <0x68>;
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 2/3] ARM: dts: imx6qdl-nitrogen6_som2: fix rv4162 compatible
2017-04-19 20:22 ` [PATCH 2/3] ARM: dts: imx6qdl-nitrogen6_som2: " Alexandre Belloni
@ 2017-04-20 9:08 ` Gary Bisson
0 siblings, 0 replies; 11+ messages in thread
From: Gary Bisson @ 2017-04-20 9:08 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Shawn Guo, Sascha Hauer, Fabio Estevam, linux-arm-kernel, linux-kernel
Hi Alexandre,
On Wed, Apr 19, 2017 at 10:22:03PM +0200, Alexandre Belloni wrote:
> The rv4162 vendor is microcrystal, not ST.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Gary Bisson <gary.bisson@boundarydevices.com>
Thanks for fixing it.
Regards,
Gary
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/3] ARM: dts: imx7d-nitrogen7: fix rv4162 compatible
2017-04-19 20:22 [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible Alexandre Belloni
2017-04-19 20:22 ` [PATCH 2/3] ARM: dts: imx6qdl-nitrogen6_som2: " Alexandre Belloni
@ 2017-04-19 20:22 ` Alexandre Belloni
2017-04-20 9:09 ` Gary Bisson
2017-04-20 9:08 ` [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: " Gary Bisson
2017-05-03 8:50 ` Shawn Guo
3 siblings, 1 reply; 11+ messages in thread
From: Alexandre Belloni @ 2017-04-19 20:22 UTC (permalink / raw)
To: Shawn Guo, Gary Bisson
Cc: Sascha Hauer, Fabio Estevam, linux-arm-kernel, linux-kernel,
Alexandre Belloni
The rv4162 compatbile string is missing the vendor part, add it.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
arch/arm/boot/dts/imx7d-nitrogen7.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx7d-nitrogen7.dts b/arch/arm/boot/dts/imx7d-nitrogen7.dts
index 5d98e2b5d54b..a44f992051ac 100644
--- a/arch/arm/boot/dts/imx7d-nitrogen7.dts
+++ b/arch/arm/boot/dts/imx7d-nitrogen7.dts
@@ -279,7 +279,7 @@
status = "okay";
rtc@68 {
- compatible = "rv4162";
+ compatible = "microcrystal,rv4162";
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_i2c2_rv4162>;
reg = <0x68>;
--
2.11.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH 3/3] ARM: dts: imx7d-nitrogen7: fix rv4162 compatible
2017-04-19 20:22 ` [PATCH 3/3] ARM: dts: imx7d-nitrogen7: " Alexandre Belloni
@ 2017-04-20 9:09 ` Gary Bisson
0 siblings, 0 replies; 11+ messages in thread
From: Gary Bisson @ 2017-04-20 9:09 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Shawn Guo, Sascha Hauer, Fabio Estevam, linux-arm-kernel, linux-kernel
Hi Alexandre,
On Wed, Apr 19, 2017 at 10:22:04PM +0200, Alexandre Belloni wrote:
> The rv4162 compatbile string is missing the vendor part, add it.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Gary Bisson <gary.bisson@boundarydevices.com>
Thanks for fixing it.
Regards,
Gary
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible
2017-04-19 20:22 [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible Alexandre Belloni
2017-04-19 20:22 ` [PATCH 2/3] ARM: dts: imx6qdl-nitrogen6_som2: " Alexandre Belloni
2017-04-19 20:22 ` [PATCH 3/3] ARM: dts: imx7d-nitrogen7: " Alexandre Belloni
@ 2017-04-20 9:08 ` Gary Bisson
2017-05-03 8:50 ` Shawn Guo
3 siblings, 0 replies; 11+ messages in thread
From: Gary Bisson @ 2017-04-20 9:08 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Shawn Guo, Sascha Hauer, Fabio Estevam, linux-arm-kernel, linux-kernel
Hi Alexandre,
On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote:
> The rv4162 vendor is microcrystal, not ST.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Gary Bisson <gary.bisson@boundarydevices.com>
Thanks for fixing it.
Regards,
Gary
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible
2017-04-19 20:22 [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible Alexandre Belloni
` (2 preceding siblings ...)
2017-04-20 9:08 ` [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: " Gary Bisson
@ 2017-05-03 8:50 ` Shawn Guo
2017-05-03 22:14 ` Fabio Estevam
2017-05-03 22:16 ` Alexandre Belloni
3 siblings, 2 replies; 11+ messages in thread
From: Shawn Guo @ 2017-05-03 8:50 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Gary Bisson, Sascha Hauer, Fabio Estevam, linux-arm-kernel, linux-kernel
On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote:
> The rv4162 vendor is microcrystal, not ST.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> index bad3c9f9eeac..b63134e3b51a 100644
> --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> @@ -408,7 +408,7 @@
> };
>
> rtc: rtc@68 {
> - compatible = "st,rv4162";
> + compatible = "microcrystal,rv4162";
The compatible is not documented?
Shawn
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_rv4162>;
> reg = <0x68>;
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible
2017-05-03 8:50 ` Shawn Guo
@ 2017-05-03 22:14 ` Fabio Estevam
2017-05-03 22:27 ` Alexandre Belloni
2017-05-03 22:16 ` Alexandre Belloni
1 sibling, 1 reply; 11+ messages in thread
From: Fabio Estevam @ 2017-05-03 22:14 UTC (permalink / raw)
To: Shawn Guo
Cc: Alexandre Belloni, Gary Bisson, Fabio Estevam, linux-arm-kernel,
Sascha Hauer, linux-kernel
Hi Shawn,
On Wed, May 3, 2017 at 5:50 AM, Shawn Guo <shawnguo@kernel.org> wrote:
>> rtc: rtc@68 {
>> - compatible = "st,rv4162";
>> + compatible = "microcrystal,rv4162";
>
> The compatible is not documented?
This compatible has been added in a897bf138c9b443 ("rtc: m41t80: Add
proper compatible for rv4162") in linux-next, so it will be present in
4.12-rc1.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible
2017-05-03 22:14 ` Fabio Estevam
@ 2017-05-03 22:27 ` Alexandre Belloni
0 siblings, 0 replies; 11+ messages in thread
From: Alexandre Belloni @ 2017-05-03 22:27 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, Gary Bisson, Fabio Estevam, linux-arm-kernel,
Sascha Hauer, linux-kernel
On 03/05/2017 at 19:14:42 -0300, Fabio Estevam wrote:
> Hi Shawn,
>
> On Wed, May 3, 2017 at 5:50 AM, Shawn Guo <shawnguo@kernel.org> wrote:
>
> >> rtc: rtc@68 {
> >> - compatible = "st,rv4162";
> >> + compatible = "microcrystal,rv4162";
> >
> > The compatible is not documented?
>
> This compatible has been added in a897bf138c9b443 ("rtc: m41t80: Add
> proper compatible for rv4162") in linux-next, so it will be present in
> 4.12-rc1.
Yes, and to be clear, both patches are independent and can be applied
in any order because the iéC core will still continue to match the
i2c_device_ids if the compatible doesn't match.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible
2017-05-03 8:50 ` Shawn Guo
2017-05-03 22:14 ` Fabio Estevam
@ 2017-05-03 22:16 ` Alexandre Belloni
2017-05-04 13:18 ` Shawn Guo
1 sibling, 1 reply; 11+ messages in thread
From: Alexandre Belloni @ 2017-05-03 22:16 UTC (permalink / raw)
To: Shawn Guo
Cc: Gary Bisson, Sascha Hauer, Fabio Estevam, linux-arm-kernel, linux-kernel
On 03/05/2017 at 16:50:12 +0800, Shawn Guo wrote:
> On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote:
> > The rv4162 vendor is microcrystal, not ST.
> >
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> > arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > index bad3c9f9eeac..b63134e3b51a 100644
> > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > @@ -408,7 +408,7 @@
> > };
> >
> > rtc: rtc@68 {
> > - compatible = "st,rv4162";
> > + compatible = "microcrystal,rv4162";
>
> The compatible is not documented?
>
No, it wasn't. Like for many i2c devices, the driver predates DT and
didn't need any specific code to be used from DT. Basically, the i2c
core was using the i2c_device_ids to match the DT compatible string.
This is changing since cabcf4f6be658b2d4bea26dee89d08fdf67d6811.
I'm planning to document all the undocumented ones soon.
> Shawn
>
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_rv4162>;
> > reg = <0x68>;
> > --
> > 2.11.0
> >
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible
2017-05-03 22:16 ` Alexandre Belloni
@ 2017-05-04 13:18 ` Shawn Guo
0 siblings, 0 replies; 11+ messages in thread
From: Shawn Guo @ 2017-05-04 13:18 UTC (permalink / raw)
To: Alexandre Belloni
Cc: Gary Bisson, Sascha Hauer, Fabio Estevam, linux-arm-kernel, linux-kernel
On Thu, May 04, 2017 at 12:16:20AM +0200, Alexandre Belloni wrote:
> On 03/05/2017 at 16:50:12 +0800, Shawn Guo wrote:
> > On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote:
> > > The rv4162 vendor is microcrystal, not ST.
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > > ---
> > > arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > index bad3c9f9eeac..b63134e3b51a 100644
> > > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > @@ -408,7 +408,7 @@
> > > };
> > >
> > > rtc: rtc@68 {
> > > - compatible = "st,rv4162";
> > > + compatible = "microcrystal,rv4162";
> >
> > The compatible is not documented?
> >
>
> No, it wasn't. Like for many i2c devices, the driver predates DT and
> didn't need any specific code to be used from DT. Basically, the i2c
> core was using the i2c_device_ids to match the DT compatible string.
> This is changing since cabcf4f6be658b2d4bea26dee89d08fdf67d6811.
>
> I'm planning to document all the undocumented ones soon.
I applied all 3 patches. Please remember to document the compatible.
Shawn
^ permalink raw reply [flat|nested] 11+ messages in thread