* [PATCH] usb: misc: legousbtower: Fix memory leak
@ 2017-05-04 19:51 Maksim Salau
2017-05-05 7:32 ` Heikki Krogerus
0 siblings, 1 reply; 2+ messages in thread
From: Maksim Salau @ 2017-05-04 19:51 UTC (permalink / raw)
To: Heikki Krogerus, Juergen Stuber, Greg Kroah-Hartman,
legousb-devel, linux-usb, linux-kernel,
Alfredo Rafael Vicente Boix
Cc: Maksim Salau
get_version_reply is not freed if function returns with success.
Memory leak was introduced by commit 942a48730faf149ccbf3e12ac718aee120bb3529
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Maksim Salau <maksim.salau@gmail.com>
---
drivers/usb/misc/legousbtower.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c
index aa3c280..0782ac6 100644
--- a/drivers/usb/misc/legousbtower.c
+++ b/drivers/usb/misc/legousbtower.c
@@ -926,6 +926,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device
USB_MAJOR, dev->minor);
exit:
+ kfree(get_version_reply);
return retval;
error:
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: misc: legousbtower: Fix memory leak
2017-05-04 19:51 [PATCH] usb: misc: legousbtower: Fix memory leak Maksim Salau
@ 2017-05-05 7:32 ` Heikki Krogerus
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Krogerus @ 2017-05-05 7:32 UTC (permalink / raw)
To: Maksim Salau
Cc: Juergen Stuber, Greg Kroah-Hartman, legousb-devel, linux-usb,
linux-kernel, Alfredo Rafael Vicente Boix
Hi,
On Thu, May 04, 2017 at 10:51:52PM +0300, Maksim Salau wrote:
> get_version_reply is not freed if function returns with success.
> Memory leak was introduced by commit 942a48730faf149ccbf3e12ac718aee120bb3529
Pointing the commit like that is probable fine, but you should also
use "Fixes" tag:
Fixes: 942a48730faf ("usb: misc: legousbtower: Fix buffers on stack")
Please check Documentation/process/submitting-patches.rst for more
information.
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
You are signing the patch for me which you should not be doing in this
case. More appropriate tag would be for example "Suggested-by" or
something like that. There is more information about this too in
Documentation/process/submitting-patches.rst
> Signed-off-by: Maksim Salau <maksim.salau@gmail.com>
> ---
> drivers/usb/misc/legousbtower.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c
> index aa3c280..0782ac6 100644
> --- a/drivers/usb/misc/legousbtower.c
> +++ b/drivers/usb/misc/legousbtower.c
> @@ -926,6 +926,7 @@ static int tower_probe (struct usb_interface *interface, const struct usb_device
> USB_MAJOR, dev->minor);
>
> exit:
> + kfree(get_version_reply);
> return retval;
>
> error:
> --
> 2.9.3
Thanks,
--
heikki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-05 7:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-04 19:51 [PATCH] usb: misc: legousbtower: Fix memory leak Maksim Salau
2017-05-05 7:32 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).