From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753405AbdEELWK (ORCPT ); Fri, 5 May 2017 07:22:10 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:43447 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751180AbdEELWI (ORCPT ); Fri, 5 May 2017 07:22:08 -0400 Date: Fri, 5 May 2017 04:22:00 -0700 From: Christoph Hellwig To: Geert Uytterhoeven Cc: Christoph Hellwig , Geert Uytterhoeven , Ingo Molnar , Peter Zijlstra , Oleg Nesterov , Thomas Gleixner , "linux-kernel@vger.kernel.org" , linux-spi Subject: Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules Message-ID: <20170505112200.GA2939@infradead.org> References: <1493977751-19340-1-git-send-email-geert+renesas@glider.be> <20170505100729.GA21589@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 05, 2017 at 01:08:47PM +0200, Geert Uytterhoeven wrote: > Of course I can add a flag to indicate abortion, and just call complete_all(), > but IMHO that's a bit silly, given wait_for_completion_interruptible() already > provides this side channel information through -ERESTARTSYS. Even if this was the right channel (which I'm not sure about) it should be provided as an abstract API operating on the completion.