From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753134AbdEEMaj (ORCPT ); Fri, 5 May 2017 08:30:39 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:58525 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbdEEMai (ORCPT ); Fri, 5 May 2017 08:30:38 -0400 Date: Fri, 5 May 2017 14:30:35 +0200 From: Maxime Ripard To: icenowy@aosc.io Cc: Chen-Yu Tsai , Rob Herring , linux-clk , devicetree , linux-arm-kernel , linux-kernel , dri-devel , linux-sunxi , linux-kernel-owner@vger.kernel.org Subject: Re: [linux-sunxi] [PATCH v6 11/13] ARM: dts: sun8i: add DE2 nodes for V3s SoC Message-ID: <20170505123035.pwh3idz73ujrd3hx@lukather> References: <20170504114858.9008-1-icenowy@aosc.io> <20170504114858.9008-12-icenowy@aosc.io> <8ad5de02ffc13348dfc71e9ec203205c@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="st47prdbm2t3ondk" Content-Disposition: inline In-Reply-To: <8ad5de02ffc13348dfc71e9ec203205c@aosc.io> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --st47prdbm2t3ondk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 05, 2017 at 04:53:43PM +0800, icenowy@aosc.io wrote: > > > + de2_clocks: clock@1000000 { > > > + compatible =3D "allwinner,sun50i-h5-de2-clk"; > >=20 > > I am a bit skeptical about this. Since the V3S only has one mixer, do > > the clocks > > for the second one even exist? >=20 > It's described in the de_clock.c in the BSP source code, and in hardware > these bits can be really set (although without clock output). >=20 > So I use this compatible which has still the extra clocks. If it's not usable, then it shouldn't be in the code, it's basically dead code. --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --st47prdbm2t3ondk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAABCAAGBQJZDHBnAAoJEBx+YmzsjxAgcXIQAMA633vVYPislWdk3mRPf9vc KWuBNS3Yg/XFtOi9qgzF9iGu8G0NeeG7FSBVoD+PSg6IsCenv936Iz2sOQc2x6X2 PHPANnL32IchPRVZYBJLZNTee2om+2Yil0soKGaix6IUb+RdWedIcwcI6bfyM5jM zustjt83PZcd7ZhUV4NjZcLSUiITjaapNZ+fraDJNNgFepw0HepGxqubx27bfCii Abr5CZDhBQ5JaRjLbzmd2kJRFtU6u+eEmXRJyQlUsgdxra7RYbaXS80TBd14faFr 55W0+ZJKVbgAHiy/eRIz0WO5H1X8YFHEZv6OxgH2KtS/oWasHI7jjNsN7BFxf5Ou bAO2GZHcgLI+FbSVqC7riSbGGlxZy/M/x2WFcWJzZ3sW7jUhAjBh05pqfKe/ixdT IhteMAcLnxClrE+GDX3r3XMIwf4OTGP3dbShkBzFQu2lv36Wq1pfWWn9qNkUA/Sr vrQmz+ZtqxrFx5wgHAL3r1HtbN3XSAXGivhZpXKsKIPkqxGhsrRTnIbu4FZPFGI/ jSP1Zs6iNdrllwU2iBbRIvskl1kLJSqTOMMekfaSAvDoq1ne552lgsJU2YzjVKzg IWsShJxplWLGdLOMwRmhKcyxApoPrwYgSfREtsu0XvsvdBQTJ0lkjL5MVIcOga3B Y30eWJuKrcwxzh6A+kP3 =ZXop -----END PGP SIGNATURE----- --st47prdbm2t3ondk--