From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755907AbdEEWTy (ORCPT ); Fri, 5 May 2017 18:19:54 -0400 Received: from mail-cys01nam02on0040.outbound.protection.outlook.com ([104.47.37.40]:49763 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752744AbdEEWTw (ORCPT ); Fri, 5 May 2017 18:19:52 -0400 Authentication-Results: caviumnetworks.com; dkim=none (message not signed) header.d=none;caviumnetworks.com; dmarc=none action=none header.from=cavium.com; Date: Sat, 6 May 2017 00:19:34 +0200 From: Robert Richter To: Geetha sowjanya Cc: will.deacon@arm.com, robin.murphy@arm.com, lorenzo.pieralisi@arm.com, hanjun.guo@linaro.org, sudeep.holla@arm.com, iommu@lists.linux-foundation.org, jcm@redhat.com, linux-kernel@vger.kernel.org, catalin.marinas@arm.com, sgoutham@cavium.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, geethasowjanya.akula@gmail.com, linu.cherian@cavium.com, Charles.Garcia-Tobin@arm.com, Geetha Sowjanya Subject: Re: [PATCH v3 5/7] ACPI/IORT: Fixup SMMUv3 resource size for Cavium ThunderX2 SMMUv3 model Message-ID: <20170505221934.GX16981@rric.localdomain> References: <1493986091-30521-1-git-send-email-gakula@caviumnetworks.com> <1493986091-30521-6-git-send-email-gakula@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493986091-30521-6-git-send-email-gakula@caviumnetworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.229.95.138] X-ClientProxiedBy: DB6PR02CA0023.eurprd02.prod.outlook.com (10.170.218.164) To BY2PR07MB2344.namprd07.prod.outlook.com (10.166.114.146) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0310fb3d-15d1-45e7-3881-08d49404d714 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:BY2PR07MB2344; X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2344;3:2J6BNIVZdvGQd+o0sTTUr61lbLme5ggRDLX8BjTz1w4jGy7o+EsEVd2p/o506Y4OMBMf/Y2sri/a8LvX7XsLScxW+dfHO4RFWk1SDtWvj3CkeUoqlxtnabQB//Y/TRHgAzUn6C+9Mlg7rgDKbeCW/yIP/RZHw9AuyJd4/D+bKod19/U1zlh4KhaQQbzQG5fvawHdBPdiAR70dlhxAK/pnuH53zX+OG22cZoc+JPKx+RPJjBCpVFyF/YmC7N48cq8qHhp3k2XFrKXXHG7+Vuy13d5hzzaqNZTUnCgdtkemcHTaB5rJokzk3EtKAMpAjF0KLFbY9C8myQnw96S3Xj9Gw==;25:KthGcyTK1COlAPYXoBISYGwdJPDe7AlyrEkwUIoEpds3m+OqCVA+gxLcILNOTjYvSko2sNyMpn57saeSLW6J4XN5f/1oJwkQ+W3OPNcC+qkwpXMgcRbVoKZtS9F2PN4PmXEssuzELrY/nxc5tt1vKq42GY0pre6/fe5f9PD76SpgnCSs2kDmlUzuVm5BQ4Neq//P96OshzLof+K9z0JVFvf/IUq9jo+NNI4aS1+kP55krtM4Y7PjtRb4AULm31U9QMWO8SA/dZxmi54IdfziwD2ihFCUJvGFQpp4LBq2qKXbbX5iz+fGzhUuluMMvtaM6UpkJDIMWeV4k5SZ3VBpie0u2+TcdPLV/zaLP8vUS0Eof/AKcCkqBTRTRSv2ROCoAu11YizPUEqDgvgwD+K9Qxb/kdhw1zuW9NvAvfql3LLNBPy2NPTbVNnD6S9xC+ru9s4kVKCCQvVLv2CgjPnrn71v5LgG7axa3k+RVYXTSVM= X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2344;31:SB2DLNfVXzrCsPzMyhdRi5SBlBckgOEQm23IBLTgCBkb+Uw21txae9OmswfTUvkAm9fQ7m3BabO6frDJBAMrzSh9hk8z4bF2T1Ko2r7VdhSBcvd/PmQHUtn23/BObqU4fmZ+16kIdprmaFOe3eH/PWPNLAr28BxYOc9ziiItAwgihwYSlp21kf7eVoZK+0hR7HovIvGBbRS7EN+m9N5bOfBM62QzMuciQAYf05ZmKpg=;20:fy99lLRphR7o6OlArYplDhUe5o+PAOMru5k0SrovR7mURD82t+BlLT1Vn4bCaM0dU7C+3bbD8ZJplePghTrDVF1mNTgwb6pMJ4inM3aUDrDSQl4R8QDguTpO74FzkwqsM4zTD0nAzcQ61lP3qP5ApeJUQUZxowsEmjELMXr4AH4zvQnEO+vqcTX45t1J3DmnD2DR7S4OMZyHFizMs9MqUiGrMxfXF95sYAv0Vco2e5TDSWgp/JAlYp5H4uiiT5/ATDt4YYXKGm3NI+yBLxg278OzxF68RjtVQN+Vvc6Etx7zmNt4A57r9fSG5tKLiiWm3jw+a+xhG12cExu+x+OTtMmGb1+iX4SjNX1ZHqffO8WXb0IDbCQmL79MWVxXStwLFFeRSvyI1dR2iS6BXItK36H5PgbCpfCe1uZ4qSHi2MLpMHdm07r1vHJ2N+FKvVAweUctn95LrBDRYCmxUJokme0S8ON6BH5kKbQKRC8u7v9G44QL2cJkS7AcyYyi91MB X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(6041248)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123562025)(20161123555025)(6072148);SRVR:BY2PR07MB2344;BCL:0;PCL:0;RULEID:;SRVR:BY2PR07MB2344; X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2344;4:HdbHPMJnuR9HSBYjxUOnJDiC526niC8USKPqXykkTJmgTiqd+KRh+iHqEYmU21Les68ZEAQ7mqLoQKSFfABVVS0hY9NilwPUsioFzk3nOMVty+x2fHTCjKnDrgKcuZ/T+c1q3cckObBVROZD9IgGHgy6D9SPdmFhMhYvlexttKq6JLQldtbhpKwvzo8D90v0kTkAIWoOsWeiaez3Mi7o4py0GjixZWebYxRm2dY7n8POHdzkGPz8S+jEgLzdCDlcuipwuc4Cw8MN1TXws605qDRodjPhPmM22QW5aCTjVOboStiLZVQfak2jpAkCzSIYTPhhkMQJJ9ACwVDZp0uantjAtjSRccYeXV7m1cc8cWnXAw3u5SNN7BImcG7202+9ONfQJnFuqi5pK1g2ISgvdhE8nFJkYvkYalp6roUoi98xLDndCYTfzm6m7ZP4mAuIS121KNd8qTCJU48/sQJZZHg3MvyG6LgZBQiF2mUVh4m+sjUKamYjvlPfj6zgizlsGuhDrQAzk8RXMAPxhC71kA2htFBNOdW2aDQWpuhwFUvIZWIdWaP2pIuB/aaqQavjFZE8mXLCIvo7V5fSvm0PxzhmbIHI3rk16jfAyFl6+451W3YJN7+2s8c4QH96o5zCahJADggXuD3tNxdiSDiiSgzxKiOmRxsBl90CmBxVCHkWZV+OG66xbOp9vMWByE0WEbUjAxRATvK+3xyd/fhVZsDw5dbjp2Wp0ISih5XEAuBYViwtucCnf4hIBCOGZzAdcmI3W87AWH0Xe/B9+RnMmglHmDPkBXxTakI8jhYl1Y0= X-Forefront-PRVS: 02981BE340 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(39410400002)(39850400002)(39400400002)(39840400002)(39450400003)(24454002)(4001350100001)(8676002)(81166006)(478600001)(189998001)(6506006)(6246003)(54356999)(83506001)(42186005)(107886003)(25786009)(4326008)(53546009)(6862004)(38730400002)(110136004)(47776003)(1076002)(50466002)(50986999)(6666003)(2950100002)(76176999)(5660300001)(55016002)(229853002)(66066001)(86362001)(6116002)(53936002)(2906002)(7416002)(7736002)(305945005)(3846002)(33656002)(9686003)(23726003)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR07MB2344;H:rric.localdomain;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR07MB2344;23:g0sE7wr9S+Y3IHKR41mdWBoUYnwaliWiFkmg5/pGx?= =?us-ascii?Q?iAmuucEL12A3cJh1VD4Q94sMxjmc6KC5iNP/IyiAo5RefiloJHxqgGey+xSJ?= =?us-ascii?Q?Q0wWQFoOePo7kyqCkr3SPPxPgOxoPCTqKEuKJZ88T1VBvOTaUV15Nw1LfZlN?= =?us-ascii?Q?lczLmqZe3RiYkQ2rTPsR/r/gHfW50aTrZdJsWYMnbcPNkDqWhFMZ05mg6fQt?= =?us-ascii?Q?0SECFtgluJRPZAZ93kkEoKgZ+gfx7+ea4Sdkd/fbYp3qWwZHYh8I2PVLSmRH?= =?us-ascii?Q?RhDyI2rRnSlJ+5cuwLY4kFCJU7gjQASl068YN8hkVd0kzwDCHedGBXtISdqD?= =?us-ascii?Q?qlRwjm8n5EZSa0a92XxZ+/q2EFvvbLapiecSisaNxi65OFbaxIPwzSu5Z0LU?= =?us-ascii?Q?VKGAWLrEuHXTmpkyRXDODLLkJ6Wn+NBph23kGBtfd6cBWJeu9leAUVJFKZFX?= =?us-ascii?Q?H6iVwgB/RObcSBkAAJAfvG3Z8PmFhiIe+nC4+2IIpuFP8VflLSq7ZDSHC3N5?= =?us-ascii?Q?AaxNj4hT5JLLae6JUAsUSjbVikApiz7sMbTihkKA94YvAG1Ll55JrSPdB2A4?= =?us-ascii?Q?iyvP0sBwact2p2eiaU7OwuTiwBhwyvAh3I1c6oeE1BxvGDDzysTHrCzzrdzb?= =?us-ascii?Q?5vdXHqDCQ8u8z3ZSLIZXehwJfXGEBMpCLG2jF7XSbokAcwteWBQNWyEGwwYP?= =?us-ascii?Q?EXdYqmU/4Y/QbTF4mlRGilZqJXauhkSULvFRejigkAp1nps1LOZZyCaA7r0J?= =?us-ascii?Q?MTTydjJBtRgwfdJSmzfdLt7FKc70MkanjyUWSMG5tdh+dRlmJlGnUXr+FXLN?= =?us-ascii?Q?RbxleeDaw/OnXa/+bQRjc/ESa4fVa79trcnvbyxOL0xBqGy3NYpxR/jcL8Ap?= =?us-ascii?Q?iDXhsKGHZGlWYV8TuvI6SRgVHv3DtmQb3bcDastRSDECO3lWnpQYlPiOqB8a?= =?us-ascii?Q?uzcotJscX3jWcxp2j5+lgAQGbkO2AC+z5B1mbxkyNRL2uRfuLmfrs+s4w6Or?= =?us-ascii?Q?p+sUhJjNlP0CZvN01rxEgBKlNYEduPFrZNRmN2GB11fyfUH+KIPM3x+iKvZa?= =?us-ascii?Q?rtd2TIHb25ZzWOZnLKn8VjnYaRiEY+YdvxcawJTbXRMnwLA2g2c3kiqj0Eo+?= =?us-ascii?Q?imh041qbRynmeLSHgvyENhGuo9oDirQhV8tQnRTstfCt4YxuJOkw72u66o83?= =?us-ascii?Q?atQ3NATDMl0Tu18Z1GNbV5+xBrvLL27UH8v?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2344;6:29hFD+3jPk7viU3iyOVez+mFWVijOVzslS1OdXVKWfl2LoVn6aoWSw/DZFLi30Pe729Ek59xNjNx4Wp5UepqcTGbvmieMKjy4SPZIk+y6mVFfBy9KV9EeHQxL5OAxfg+45xNPgffwiFGC9Chqgor5iYGehIwZU8uCi+vLki31WBEIabZjT+krP4Ryw0vVHDUxtDpuexANxDh9EFEEE9vEYTTvWIeEk3kRpj5Kx2LDPgmXNIVOM4x4v1IGBaE3n0OFvP36X/yfPzsI+jzHppDkmwBVnvS4vLrT+hWZteZ8PGxm8pfcbE2QxqUSovgCh2gffxeSGKDJE7SUPh/jS4CEerOcOjgoSswJDGsGfCVxhwflt5iSkC1ZDBBgoKyeo65ul03olsPRG+aHLywVyjnDc5CYVoRVR7N9v3iPf1BJJ+lBp5PlDYwvYTjN14EgeuKfq/tpZktOggkEf/OvVjPsY90EUdGQ5smfFPMW9lLazD3KancvwWCnpAvbg/FuCs5UoWfLiRE2KQxSoLyfUJhhA==;5:DURuG7bKo9Y2wcUFNRuWQTfwk8oM1gkvVTsZQ4uuxTpSNv8fHsTVgDS52kfWylc3sGbWrg2sqMR2osK+8NK/82GqQUOpWyjkmdkad+ZpCtb/PS4YpAdqlEFVXCduRdooeDBLHpXMBugDQp05D3p2CA==;24:g4hpmPTvfJdKcrZbbuurQSwkXfvYuZ5x5EOqjzWl4ak8e/NxUiyMYzV2Bc7KgxrWGP85umLaDeUnwRoBpa64wLhV9uSGNp1AKvkvPZK3Tjs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BY2PR07MB2344;7:7VVYUevV18YNXJCvwGoXP3jZAfpptMnH/1J5oEqSCLh3K0Wy22Vy6gyRvRs2fkN5SeIDSf27Tz2bji01UhqwrvssA8cte3TuUyHh/DhSukeAsn0uPbXHznlqiG/aEe6cD0gFNcUhxs9coJ+1syk4n49hv/iXbt47nh08KHuBdvW0YLIQ8/CzTS1CjoRtMwuigA4A16/+WKBoV8nVVW8HRmuqy4BjqvCBFDjFUM5+RzILm7Tod+09RmaSKSdMrTvnQ96GpQZcoIWPDJPUfCTvUYZB9vdCGoRghDTC5onoLgE5gmhpoCOpCqLvmyR7EfSM9PHNSmopdbu26r4X3lRX3A== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2017 22:19:43.8257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB2344 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05.05.17 17:38:09, Geetha sowjanya wrote: > From: Linu Cherian > > Cavium ThunderX2 implementation doesn't support second page in SMMU > register space. Hence, resource size is set as 64k for this model. > > Signed-off-by: Linu Cherian > Signed-off-by: Geetha Sowjanya > --- > drivers/acpi/arm64/iort.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) The whole patch can be dropped. See my comment in #2. -Robert > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index c5fecf9..23c5350 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -833,12 +833,20 @@ static void __init arm_smmu_v3_init_resources(struct resource *res, > { > struct acpi_iort_smmu_v3 *smmu; > int num_res = 0; > + unsigned long size = SZ_128K; > > /* Retrieve SMMUv3 specific data */ > smmu = (struct acpi_iort_smmu_v3 *)node->node_data; > > + /* > + * Override the size, for Cavium ThunderX2 implementation > + * which doesn't support the page 1 SMMU register space. > + */ > + if (smmu->model == ACPI_IORT_SMMU_V3_CAVIUM_CN99XX) > + size = SZ_64K; > + > res[num_res].start = smmu->base_address; > - res[num_res].end = smmu->base_address + SZ_128K - 1; > + res[num_res].end = smmu->base_address + size - 1; > res[num_res].flags = IORESOURCE_MEM; > > num_res++; > -- > 1.8.3.1 >