From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753756AbdEFHUG (ORCPT ); Sat, 6 May 2017 03:20:06 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33907 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbdEFHT7 (ORCPT ); Sat, 6 May 2017 03:19:59 -0400 Date: Sat, 6 May 2017 09:19:55 +0200 From: Ingo Molnar To: Linus Torvalds , Josh Poimboeuf Cc: Jiri Slaby , Andrew Morton , live-patching@vger.kernel.org, Linux Kernel Mailing List , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , Josh Poimboeuf Subject: Re: [PATCH 7/7] DWARF: add the config option Message-ID: <20170506071955.ssxpqs3g76l6eglf@gmail.com> References: <20170505122200.31436-1-jslaby@suse.cz> <20170505122200.31436-7-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Linus Torvalds wrote: > On Fri, May 5, 2017 at 5:22 AM, Jiri Slaby wrote: > > The DWARF unwinder is in place and ready. So introduce the config option > > to allow users to enable it. It is by default off due to missing > > assembly annotations. > > Who actually ends up using this? Also, why wasn't Josh Poimboeuf Cc:-ed, who de-facto maintains the x86 unwinding code? AFAICS this series is just repeating the old mistakes of the old Dwarf unwinders of trusting GCC's unwinder data. So NAK for the time being on the whole approach: NAcked-by: Ingo Molnar Thanks, Ingo