From: Baoquan He <bhe@redhat.com>
To: Bhupesh Sharma <bhsharma@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Matt Fleming <matt@codeblueprint.co.uk>
Cc: linux-kernel@vger.kernel.org, Dave Young <dyoung@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Garnier <thgarnie@google.com>,
Kees Cook <keescook@chromium.org>,
x86@kernel.org, linux-efi@vger.kernel.org,
Alex Thorlton <athorlton@sgi.com>, Russ Anderson <rja@sgi.com>,
Dimitri Sivanich <sivanich@sgi.com>, Mike Travis <travis@sgi.com>
Subject: Re: [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled
Date: Mon, 8 May 2017 09:36:49 +0800 [thread overview]
Message-ID: <20170508013649.GA2315@x1> (raw)
In-Reply-To: <CACi5LpOJe+dpJBeuZxm80pd0dX9-V=DQv_R3TDzFmn4Q1XA1SA@mail.gmail.com>
Thanks for explaining, Bhupesh.
BIOS issue of SGI uv1 is still not fixed. There's a quirk for uv1 to
use efi old map:
void __init efi_apply_memmap_quirks(void)
{
...
...
/* UV2+ BIOS has a fix for this issue. UV1 still needs the quirk. */
if (dmi_check_system(sgi_uv1_dmi))
set_bit(EFI_OLD_MEMMAP, &efi.flags);
}
And because of some reasons, redhat also need efi old_map now.
Hi Matt,
This v2 patch works on my kvm guest, however there's still problem on
SGI system. I will post v3 later after it's handled. So nack this v2
patch.
Thanks
Baoquan
On 05/08/17 at 12:07am, Bhupesh Sharma wrote:
> On Sat, May 6, 2017 at 5:06 AM, Borislav Petkov <bp@alien8.de> wrote:
> > On Fri, May 05, 2017 at 09:42:14PM +0100, Matt Fleming wrote:
> >> (Including the folks from SGI since this was hit on a UV system)
> >
> > Wasn't there a BIOS fix supplied at some point which obviated the need
> > to boot with efi=old_map on SGI boxes?
> >
>
> AFAICR, the bios fixes were provided only for SGI boxes with BIOS
> version greater than or equal to UV2 (so upstream with recent bios
> works on UV2, UV3, and UV4 hardware platforms, both with old and new
> mapping, with new mapping being the default), however the UV1
> platforms still use efi=old_map
>
> Also as mentioned above since commit
> caef78b6cdeddf4ad364f95910bba6b43b8eb9bf fixed the efi=old_map support
> on UV systems even with new bios, they should ideally all boot up
> properly in upstream both with 'nokaslr' and without 'nokaslr' in the
> bootargs when efi=old_map is used.
>
> Regards,
> Bhupesh
next prev parent reply other threads:[~2017-05-08 1:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 12:07 [PATCH v2] x86/efi: Correct ident mapping of efi old_map when kalsr enabled Baoquan He
2017-05-01 14:21 ` Thomas Garnier
2017-05-05 20:42 ` Matt Fleming
2017-05-05 23:36 ` Borislav Petkov
2017-05-07 18:37 ` Bhupesh Sharma
2017-05-08 1:36 ` Baoquan He [this message]
2017-05-08 15:25 ` Borislav Petkov
2017-05-09 3:30 ` Baoquan He
2017-05-10 2:30 ` Baoquan He
2017-05-08 3:18 ` Russ Anderson
2017-05-11 9:32 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508013649.GA2315@x1 \
--to=bhe@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=athorlton@sgi.com \
--cc=bhsharma@redhat.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mingo@redhat.com \
--cc=rja@sgi.com \
--cc=sivanich@sgi.com \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).