From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754192AbdEHLlI (ORCPT ); Mon, 8 May 2017 07:41:08 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35005 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753603AbdEHLlG (ORCPT ); Mon, 8 May 2017 07:41:06 -0400 Date: Mon, 8 May 2017 19:41:04 +0800 From: Dong Aisheng To: Stephen Boyd Cc: Dong Aisheng , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, broonie@kernel.org, yibin.gong@nxp.com, rjw@rjwysocki.net, viresh.kumar@linaro.org, mturquette@baylibre.com, shawnguo@kernel.org, fabio.estevam@nxp.com, anson.huang@nxp.com, ping.bai@nxp.com, leonard.crestez@nxp.com, octavian.purdila@nxp.com Subject: Re: [RFC PATCH 2/3] clk: add managed version of clk_bulk_get Message-ID: <20170508114104.GD18153@b29396-OptiPlex-7040> References: <1491969809-20154-1-git-send-email-aisheng.dong@nxp.com> <1491969809-20154-3-git-send-email-aisheng.dong@nxp.com> <20170413143727.GE24254@b29396-OptiPlex-7040> <20170422025837.GU7065@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170422025837.GU7065@codeaurora.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 21, 2017 at 07:58:37PM -0700, Stephen Boyd wrote: > On 04/13, Dong Aisheng wrote: > > On Wed, Apr 12, 2017 at 12:03:28PM +0800, Dong Aisheng wrote: > > > > drivers/built-in.o: In function `devm_clk_bulk_get': > > >> (.text+0x1930e): undefined reference to `clk_bulk_get' > > drivers/built-in.o: In function `devm_clk_bulk_release': > > >> clk-devres.c:(.text+0x19370): undefined reference to `clk_bulk_put' > > > > clk_bulk_get is defined in clkdev.c which depends on CONFIG_CLKDEV_LOOKUP. > > However, some platforms like m68k may not select CLKDEV_LOOKUP but > > select HAVE_CLK. Thus compiling devm_clk_bulk_get may cause a undefined > > reference to 'clk_bulk_get'. > > > > Since clk_bulk_get is built upon the platform specific clk_get api, > > clk_bulk_get can also be used by that platform accordingly. > > > > Then we probably could move clk_bulk_get into clk-devres.c as well which > > is controlled by common CONFIG_HAVE_CLK to benifit all platforms. > > clk-devres is for devm* things. I'd just make another file for > now, clk-bulk.c or something like that. When everyone moves to > common clk, we can fold it into clk.c, or not because clk.c is > rather large right now. > Thanks for the suggestion. Much agree with you that getting a new file to handle them is better. Will do them in clk-bulk.c first. Regards Dong Aisheng > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project