From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752060AbdEHQa7 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 8 May 2017 12:30:59 -0400
Received: from mail.kernel.org ([198.145.29.136]:58856 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751425AbdEHQa6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 8 May 2017 12:30:58 -0400
Date: Mon, 8 May 2017 13:30:52 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: SeongJae Park <sj38.park@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Taeung Song <treeze.taeung@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf probe: Fix examples section of documentation
Message-ID: <20170508163052.GH7891@kernel.org>
References: <20170507103642.30560-1-sj38.park@gmail.com>
 <20170509001957.9e6458593fc1b8e9b344761d@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170509001957.9e6458593fc1b8e9b344761d@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.8.0 (2017-02-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, May 09, 2017 at 12:19:57AM +0900, Masami Hiramatsu escreveu:
> On Sun,  7 May 2017 19:36:42 +0900
> SeongJae Park <sj38.park@gmail.com> wrote:
> 
> > An example in perf-probe documentation for pattern of function name
> > based probe addition is not providing example command for the case.
> > This commit fixes the example to give appropriate example command.
> > 
> > Signed-off-by: SeongJae Park <sj38.park@gmail.com>
> 
> Good catch!
> 
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks, I added the suggested Fixes: tag,

- Arnaldo
 
> Thank you!
> 
> > ---
> >  tools/perf/Documentation/perf-probe.txt | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tools/perf/Documentation/perf-probe.txt b/tools/perf/Documentation/perf-probe.txt
> > index e6c9902c6d82..165c2b1d4317 100644
> > --- a/tools/perf/Documentation/perf-probe.txt
> > +++ b/tools/perf/Documentation/perf-probe.txt
> > @@ -240,9 +240,13 @@ Add a probe on schedule() function 12th line with recording cpu local variable:
> >   or
> >   ./perf probe --add='schedule:12 cpu'
> >  
> > - this will add one or more probes which has the name start with "schedule".
> > +Add one or more probes which has the name start with "schedule".
> >  
> > - Add probes on lines in schedule() function which calls update_rq_clock().
> > + ./perf probe schedule*
> > + or
> > + ./perf probe --add='schedule*'
> > +
> > +Add probes on lines in schedule() function which calls update_rq_clock().
> >  
> >   ./perf probe 'schedule;update_rq_clock*'
> >   or
> > -- 
> > 2.12.0
> > 
> 
> 
> -- 
> Masami Hiramatsu <mhiramat@kernel.org>