From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753451AbdEHQj6 (ORCPT ); Mon, 8 May 2017 12:39:58 -0400 Received: from mail.kernel.org ([198.145.29.136]:60862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751586AbdEHQj5 (ORCPT ); Mon, 8 May 2017 12:39:57 -0400 Date: Mon, 8 May 2017 13:39:52 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim Subject: Re: [PATCH v2 3/4] perf config: Correctly check whether it is from system config Message-ID: <20170508163952.GJ7891@kernel.org> References: <1494241665-32472-1-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494241665-32472-1-git-send-email-treeze.taeung@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, May 08, 2017 at 08:07:45PM +0900, Taeung Song escreveu: > Currently section's from_system_config was checked twice. you mean: "The item->from_system_config is not being checked when iterating over section->items, instead section->from_system_config is being checked multiple times, fix this" ? > So adjust it in order to correctly check not only section's > but also item's from_system_config. > > Cc: Jiri Olsa > Cc: Namhyung Kim > Signed-off-by: Taeung Song > --- > tools/perf/builtin-config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c > index 0d38599..2a6ca0d 100644 > --- a/tools/perf/builtin-config.c > +++ b/tools/perf/builtin-config.c > @@ -56,7 +56,7 @@ static int set_config(struct perf_config_set *set, const char *file_name) > fprintf(fp, "[%s]\n", section->name); > > perf_config_items__for_each_entry(§ion->items, item) { > - if (!use_system_config && section->from_system_config) > + if (!use_system_config && item->from_system_config) > continue; > if (item->value) > fprintf(fp, "\t%s = %s\n", > -- > 2.7.4