From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753218AbdEIMgw (ORCPT <rfc822;w@1wt.eu>);
        Tue, 9 May 2017 08:36:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46214 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752461AbdEIMgv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 May 2017 08:36:51 -0400
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8FC8480F9A
Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8FC8480F9A
Date: Tue, 9 May 2017 14:36:46 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools: Support srccode output
Message-ID: <20170509123646.GB9983@krava>
References: <20170509120638.9454-1-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170509120638.9454-1-andi@firstfloor.org>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 09 May 2017 12:36:50 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, May 09, 2017 at 05:06:38AM -0700, Andi Kleen wrote:

SNIP

> |12             f2();
>         0000000000400525        insn: e8 cc ff ff ff            # PRED
>         f2:
>         00000000004004f6        insn: 55
> |5        {
>         00000000004004f7        insn: 48 89 e5
>         00000000004004fa        insn: 8b 05 2c 0b 20 00
> |6              c = a / b;
> 
> Not supported for callchains currently, would need some
> layout changes there.
> 
> v2:
> Limit number of cached source files
> Delete bogus comment.
> Directly use the line number / file from the bfd lookup code
> Add prefix to source to make it easier to handle for scripts
> Avoid redundant listing of lines
> Fix include guard in srccode.h
> Use a hash table for the source lookup.
> 
> v3:
> Remove prefix. Remove unwind_inlines.
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka