LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org
Subject: Re: + mm-vmalloc-fix-vmalloc-users-tracking-properly-checkpatch-fixes.patch added to -mm tree
Date: Tue, 9 May 2017 23:10:55 +0200
Message-ID: <20170509211054.GB16325@dhcp22.suse.cz> (raw)
In-Reply-To: <591227df.Hc5/RikdRAQRbI8/%akpm@linux-foundation.org>

On Tue 09-05-17 13:34:39, Andrew Morton wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: mm-vmalloc-fix-vmalloc-users-tracking-properly-checkpatch-fixes
> 
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
> #4: 
> 1f5307b1e094 ("mm, vmalloc: properly track vmalloc users") has pulled
> 
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #12: 
> >> arch/m68k/include/asm/mcf_pgtable.h:339:43: error: 'init_mm' undeclared (first use in this function)
> 
> ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
> #36: 
> This patch reverts 1f5307b1e094 and reimplements the original fix in a
> 
> WARNING: line over 80 characters
> #71: FILE: include/linux/vmalloc.h:85:
> +static inline void *__vmalloc_node_flags_caller(unsigned long size, int node, gfp_t flags, void* caller)
> 
> ERROR: "foo* bar" should be "foo *bar"
> #71: FILE: include/linux/vmalloc.h:85:
> +static inline void *__vmalloc_node_flags_caller(unsigned long size, int node, gfp_t flags, void* caller)
> 
> ERROR: "foo* bar" should be "foo *bar"
> #92: FILE: include/linux/vmalloc.h:96:
> +					int node, gfp_t flags, void* caller);
> 
> WARNING: line over 80 characters
> #143: FILE: mm/vmalloc.c:1820:
> +void *__vmalloc_node_flags_caller(unsigned long size, int node, gfp_t flags, void *caller)
> 
> total: 4 errors, 3 warnings, 80 lines checked
> 
> NOTE: For some of the reported defects, checkpatch may be able to
>       mechanically convert to the typical style using --fix or --fix-inplace.
> 
> ./patches/mm-vmalloc-fix-vmalloc-users-tracking-properly.patch has style problems, please review.

Thanks for the fixups Andrew! While you are at it I've noticed that I
forgot to revert the comment for the originally inlined
__vmalloc_node_flags which is no longer relevant. Could to fold this as
well please?
---
diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h
index 268b3a919a5f..0e8e125b1ed6 100644
--- a/include/linux/vmalloc.h
+++ b/include/linux/vmalloc.h
@@ -87,11 +87,6 @@ static inline void *__vmalloc_node_flags_caller(unsigned long size, int node, gf
 	return __vmalloc_node_flags(size, node, flags);
 }
 #else
-/*
- * We really want to have this inlined due to caller tracking. This
- * function is used by the highlevel vmalloc apis and so we want to track
- * their callers and inlining will achieve that.
- */
 extern void *__vmalloc_node_flags_caller(unsigned long size,
 					int node, gfp_t flags, void* caller);
 #endif
-- 
Michal Hocko
SUSE Labs

           reply index

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <591227df.Hc5/RikdRAQRbI8/%akpm@linux-foundation.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170509211054.GB16325@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git
	git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git