From: Christoph Hellwig <hch@lst.de>
To: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
Cc: Jens Axboe <axboe@kernel.dk>,
hch@lst.de, sachinp <sachinp@linux.vnet.ibm.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-block <linux-block@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [linux-next][bock] [bisected c20cfc27a] WARNING: CPU: 22 PID: 0 at block/blk-core.c:2655 .blk_update_request+0x4f8/0x500
Date: Wed, 10 May 2017 09:56:42 +0200 [thread overview]
Message-ID: <20170510075642.GA10943@lst.de> (raw)
In-Reply-To: <1494343101.11532.4.camel@abdul.in.ibm.com>
On Tue, May 09, 2017 at 08:48:21PM +0530, Abdul Haleem wrote:
> A bisection for the above suspects resulted a bad commit;
>
> c20cfc27a47307e811346f85959cf3cc07ae42f9 is the first bad commit
> commit c20cfc27a47307e811346f85959cf3cc07ae42f9
> Author: Christoph Hellwig <hch@lst.de>
> Date: Wed Apr 5 19:21:07 2017 +0200
>
> block: stop using blkdev_issue_write_same for zeroing
And this effectively switches us to use the write_zeroes for SCSI.
>
> We'll always use the WRITE ZEROES code for zeroing now.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
> Signed-off-by: Jens Axboe <axboe@fb.com>
>
>
> @Christoph FYI, the machine configured with 64K page size
> >
> > WARNING: CPU: 12 PID: 0 at block/blk-core.c:2651 .blk_update_request+0x4cc/0x4e0
Can you decode which warning this is? Is it:
WARN_ON_ONCE(req->rq_flags & RQF_SPECIAL_PAYLOAD);
? In which case your setup did a partial completion of a WRITE SAME
command, which is perfectly legal according to SCSI, but a bit unusual.
next prev parent reply other threads:[~2017-05-10 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 6:25 [linux-next][bock] WARNING: CPU: 22 PID: 0 at block/blk-core.c:2655 .blk_update_request+0x4f8/0x500 Abdul Haleem
2017-05-05 14:02 ` Jens Axboe
2017-05-08 7:13 ` Abdul Haleem
2017-05-08 14:00 ` Jens Axboe
2017-05-09 9:03 ` Christoph Hellwig
2017-05-09 15:18 ` [linux-next][bock] [bisected c20cfc27a] " Abdul Haleem
2017-05-10 7:56 ` Christoph Hellwig [this message]
2017-05-10 9:49 ` Abdul Haleem
2017-05-10 17:55 ` Christoph Hellwig
2017-05-11 9:52 ` Abdul Haleem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170510075642.GA10943@lst.de \
--to=hch@lst.de \
--cc=abdhalee@linux.vnet.ibm.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=sachinp@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).