From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595AbdEJKfV (ORCPT ); Wed, 10 May 2017 06:35:21 -0400 Received: from mail-wr0-f176.google.com ([209.85.128.176]:33830 "EHLO mail-wr0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752318AbdEJKfT (ORCPT ); Wed, 10 May 2017 06:35:19 -0400 Date: Wed, 10 May 2017 11:35:17 +0100 From: Matt Fleming To: ivanhu Cc: Geliang Tang , Ard Biesheuvel , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] efi/efi_test: use memdup_user Message-ID: <20170510103517.GA6562@codeblueprint.co.uk> References: <20170505205349.GC5225@codeblueprint.co.uk> <0d6b6b9e-de5c-4eb2-f46a-d26ae058fa42@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d6b6b9e-de5c-4eb2-f46a-d26ae058fa42@canonical.com> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 08 May, at 04:18:30PM, Ivan Hu wrote: > > > On 05/06/2017 04:53 AM, Matt Fleming wrote: > >On Sat, 29 Apr, at 09:42:52AM, Geliang Tang wrote: > >>Use memdup_user() helper instead of open-coding to simplify the code. > >> > >>Signed-off-by: Geliang Tang > >>--- > >> drivers/firmware/efi/test/efi_test.c | 11 +++-------- > >> 1 file changed, 3 insertions(+), 8 deletions(-) > > > >This one looks fine. Ivan, do you want to ACK it? > > > > Looks fine to me too, ACK. Thanks! Applied, thanks everyone.