From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752789AbdEJMVH (ORCPT ); Wed, 10 May 2017 08:21:07 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:34359 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752511AbdEJMVD (ORCPT ); Wed, 10 May 2017 08:21:03 -0400 Date: Wed, 10 May 2017 14:20:55 +0200 From: Christoffer Dall To: gengdongjiu Cc: James Morse , gengdongjiu , Tyler Baicar , Christoffer Dall , Marc Zyngier , pbonzini@redhat.com, rkrcmar@redhat.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, rjw@rjwysocki.net, Len Brown , matt@codeblueprint.co.uk, robert.moore@intel.com, lv.zheng@intel.com, nkaje@codeaurora.org, zjzhang@codeaurora.org, mark.rutland@arm.com, akpm@linux-foundation.org, eun.taik.lee@samsung.com, Sandeepa Prabhu , labbott@redhat.com, shijie.huang@arm.com, rruigrok@codeaurora.org, paul.gortmaker@windriver.com, tn@semihalf.com, Fu Wei , rostedt@goodmis.org, bristot@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org, devel@acpica.org, Suzuki.Poulose@arm.com, Punit Agrawal , astone@redhat.com, harba@codeaurora.org, Hanjun Guo , John Garry , Shiju Jose , joe@perches.com, Xiongfeng Wang Subject: Re: [PATCH v3 3/3] arm/arm64: signal SIBGUS and inject SEA Error Message-ID: <20170510122055.GE28721@cbox> References: <5910AAA2.4030304@arm.com> <20170508175416.GA32234@cbox> <5911D204.7020304@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 10, 2017 at 05:15:04PM +0800, gengdongjiu wrote: > Thanks James's explanation. > > Hi Christoffer, > > On 2017/5/9 22:28, James Morse wrote: > > Hi Christoffer, > > > > On 08/05/17 18:54, Christoffer Dall wrote: > >> On Mon, May 08, 2017 at 06:28:02PM +0100, James Morse wrote: > >> I must admit I am losing track of exactly what this proposed API was > >> supposed to do. > > > > There are two, and we keep jumping between them! > > This is about two notification methods APEI has for arm64, 'SEA' and 'SEI'. > > > > SEA is synchronous and looks like a data abort. Qemu/kvmtool can inject these > > today using the KVM_GET/SET_ONE_REG API whenever it wants to. > > > > SEI uses SError, is asynchronous and can be masked. In addition these need to be > > consumed/synchronised by the ESB instruction, even when executed by a guest. > > Hardware has the necessary bits to drive all this, we need to expose an API to > > drive it. > > > > (I try to spell them out each time so I don't confuse SEI with something > > synchronous!) > > > > > > This patch was about SEA. I think you've answered our question: > > we are talking about the SEA(synchronous data abort) injection two methods: > > (1)change vcpu registers in the Qemu/kvmtools and using the KVM_GET/SET_ONE_REG API to set. Yes, if this is possible, why would you want something more? > (2)using existed in-kernel API "kvm_inject_dabt" to inject through IOCTL command from Qemu. > I'm not really going to consider this, because "use internal API from userspace" doesn't work. So this should be: (2) Introduce a new API to do X. I still think you know what my preference is; use the existing API if at all possible. Thanks, -Christoffer