From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754957AbdELDHH (ORCPT ); Thu, 11 May 2017 23:07:07 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57754 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbdELDHG (ORCPT ); Thu, 11 May 2017 23:07:06 -0400 Date: Thu, 11 May 2017 23:07:01 -0400 (EDT) Message-Id: <20170511.230701.1656036521860703475.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, rogerq@ti.com, andrew@lunn.ch, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: phy: Call bus->reset() after releasing PHYs from reset From: David Miller In-Reply-To: <20170511182417.17708-1-f.fainelli@gmail.com> References: <20170511182417.17708-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 11 May 2017 19:25:35 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Thu, 11 May 2017 11:24:16 -0700 > The API convention makes it that a given MDIO bus reset should be able > to access PHY devices in its reset() callback and perform additional > MDIO accesses in order to bring the bus and PHYs in a working state. > > Commit 69226896ad63 ("mdio_bus: Issue GPIO RESET to PHYs.") broke that > contract by first calling bus->reset() and then release all PHYs from > reset using their shared GPIO line, so restore the expected > functionality here. > > Fixes: 69226896ad63 ("mdio_bus: Issue GPIO RESET to PHYs.") > Signed-off-by: Florian Fainelli Applied, thanks Florian.