From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758004AbdEKQfC (ORCPT ); Thu, 11 May 2017 12:35:02 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:33765 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757989AbdEKQfA (ORCPT ); Thu, 11 May 2017 12:35:00 -0400 Date: Thu, 11 May 2017 09:34:47 -0700 From: Stephen Hemminger To: SF Markus Elfring Cc: devel@linuxdriverproject.org, Haiyang Zhang , "K. Y. Srinivasan" , Stephen Hemminger , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH 4/4] vmbus: Adjust five checks for null pointers Message-ID: <20170511093447.7e5b66e4@xeon-e3> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4BGZPe4003558 On Thu, 11 May 2017 18:19:21 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 11 May 2017 17:52:38 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script “checkpatch.pl” pointed information out like the following. > > Comparison to NULL could be written … > > Thus fix the affected source code places. > > Signed-off-by: Markus Elfring Please don't do these kind of checkpatch "fix ups" on existing code. The comparison with NULL is fine, doing this is just useless churn.