From: Peter Zijlstra <peterz@infradead.org>
To: Juri Lelli <juri.lelli@arm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Luca Abeni <luca.abeni@santannapisa.it>,
Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [RFC][PATCH] sched/deadline: Remove if statement before clearing throttle and yielded
Date: Thu, 11 May 2017 21:50:47 +0200 [thread overview]
Message-ID: <20170511195047.qw7tf4c42evqszhq@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170511140116.4ojn67utqjp5x2j5@e106622-lin>
On Thu, May 11, 2017 at 03:01:16PM +0100, Juri Lelli wrote:
> > - if (dl_se->dl_yielded)
> > - dl_se->dl_yielded = 0;
> > - if (dl_se->dl_throttled)
> > - dl_se->dl_throttled = 0;
> > + dl_se->dl_yielded = 0;
> > + dl_se->dl_throttled = 0;
> > }
>
> Looks good to me.
>
> Peter, any particular reason why you wanted to first check the values?
No idea, could be general paranoia on unconditional writes or something.
prev parent reply other threads:[~2017-05-11 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 13:50 [RFC][PATCH] sched/deadline: Remove if statement before clearing throttle and yielded Steven Rostedt
2017-05-11 14:01 ` Juri Lelli
2017-05-11 17:29 ` Daniel Bristot de Oliveira
2017-05-11 19:50 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170511195047.qw7tf4c42evqszhq@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bristot@redhat.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).