From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756981AbdELNYi (ORCPT ); Fri, 12 May 2017 09:24:38 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:36250 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756377AbdELNYh (ORCPT ); Fri, 12 May 2017 09:24:37 -0400 Date: Fri, 12 May 2017 06:24:34 -0700 From: Matthew Giassa To: Greg KH Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] staging: rtl8723bs: checkpatch - resolve indentation and line width Message-ID: <20170512132434.hyqrvayg66zpzrhe@darkstar> References: <1494553524-26385-1-git-send-email-matthew@giassa.net> <1494553524-26385-5-git-send-email-matthew@giassa.net> <20170512093008.GA19482@kroah.com> <20170512125744.qvkafevxzu4x422o@darkstar> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20170512125744.qvkafevxzu4x422o@darkstar> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Matthew Giassa [2017-05-12 05:57:44 -0700]: >* Greg KH [2017-05-12 11:30:08 +0200]: > >>On Thu, May 11, 2017 at 06:45:24PM -0700, Matthew Giassa wrote: >>>+#define REG_INT_MIG_8723B 0x0304 /* Interrupt Migration */ >>>+#define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor Address >>>+ */ >>>+#define REG_HQ_DESA_8723B 0x0310 /* TX High Queue Descriptor >>>+ * Address >>>+ */ >> >>Ick, that looks worse to me now, doesn't it to you? Please leave the >>original as-is. Paring down CC list to reduce noise for off-topic question. Quick question: in the trivial case, such as a simple block comment, the style guide (process/coding-style.rst) proposes this style: /* * Some comments that span over several lines until column limit. * More comments that span over several lines until column limit. */ Though I see a similar variant often used, which I use by default: /* Some comments that span over several lines until column limit. * More comments that span over several lines until column limit. */ For cases with code plus trailing (lengthy) comment, is it preferred to let it go past the 80 column limit, or to use one of the following multi-line styles? ie: Type I: #define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor * Address */ Type II (Ugly): #define REG_BCNQ_DESA_8723B 0x0308 /* TX Beacon Descriptor * Address */ Finally, would it be worth proposing the addition of this minor exception to the style guide? Thank you. -- Matthew