From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757741AbdELQr6 (ORCPT ); Fri, 12 May 2017 12:47:58 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:49662 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757271AbdELQr4 (ORCPT ); Fri, 12 May 2017 12:47:56 -0400 Date: Fri, 12 May 2017 12:47:45 -0400 From: Johannes Weiner To: Minchan Kim Cc: Huang Ying , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] mm: swap: unify swap slot free functions to put_swap_page Message-ID: <20170512164745.GB22367@cmpxchg.org> References: <87h90sb4jq.fsf@yhuang-dev.intel.com> <1494555684-11982-1-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1494555684-11982-1-git-send-email-minchan@kernel.org> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 12, 2017 at 11:21:23AM +0900, Minchan Kim wrote: > Now, get_swap_page takes struct page and allocates swap space > according to page size(ie, normal or THP) so it would be more > cleaner to introduce put_swap_page which is a counter function > of get_swap_page. Then, it calls right swap slot free function > depending on page's size. > > Cc: Johannes Weiner > Signed-off-by: Minchan Kim Acked-by: Johannes Weiner