From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759564AbdEOHzN (ORCPT <rfc822;w@1wt.eu>);
        Mon, 15 May 2017 03:55:13 -0400
Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48386 "EHLO
        mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1759363AbdEOHzK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 15 May 2017 03:55:10 -0400
Date: Sun, 14 May 2017 19:16:52 +0900
From: Mark Brown <broonie@kernel.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
        Laxman Dewangan <ldewangan@nvidia.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Douglas Anderson <dianders@chromium.org>,
        Brian Norris <briannorris@chromium.org>
Message-ID: <20170514101652.waoc5fhjzpd2emoq@sirena.org.uk>
References: <20170501183715.35375-1-mka@chromium.org>
 <20170501183715.35375-2-mka@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ivad277dvdv2q3fs"
Content-Disposition: inline
In-Reply-To: <20170501183715.35375-2-mka@chromium.org>
X-Cookie: Dealer prices may vary.
User-Agent: NeoMutt/20170306 (1.8.0)
X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5:7e7a:91ff:fede:4a45
X-SA-Exim-Mail-From: broonie@sirena.org.uk
Subject: Re: [PATCH v2 2/2] regulator: Allow for asymmetric settling times
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--ivad277dvdv2q3fs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, May 01, 2017 at 11:37:15AM -0700, Matthias Kaehlcke wrote:

>  	else if (rdev->constraints->settling_time)
>  		return rdev->constraints->settling_time;
> +	else if (rdev->constraints->settling_time_up &&
> +		 (new_uV > old_uV))
> +		return rdev->constraints->settling_time_up;
> +	else if (rdev->constraints->settling_time_down &&
> +		 (new_uV < old_uV))
> +		return rdev->constraints->settling_time_down;

It feels like we should warn if the user mixes specific up/down settling
times with the more general property, can you please send a followup
patch adding a warning for that?  It's not exactly obvious what the
precedence is and may do the wrong thing with an older kernel or
non-Linux OS.

--ivad277dvdv2q3fs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlkYLpMACgkQJNaLcl1U
h9A+IAf+JaXIIGyP2AVYmoGOHmEbQOJsucNpCBGUaM5asCtjU42IMMyRMSz6s+pU
JfGF4gHmIO7B/GuBiUiHwzB3Byzx+NBXuPxRS5jMqHmBCBWv5SIzm31fcchHf4iO
vXfLx4y9nipoUedG18CkYO8S1RwM4LiSgR7jkIF50cI3xbGszirgtM1iC5rKJrDg
ioLV84bJw5A5J+d5JRUX1iTIMrtQ3ute24Ogh0DFFAjEIaqXs//0V8+DIelv+PCI
GaZ9CMsP/5JeGwYGtLkJSo+QXOQUn0Y4SeiZEbiUxY5zqFrOpdfBMvC50dzWSrfF
FtRPQRf3r8pXg+PbDNRRTSadTiwswQ==
=lXaH
-----END PGP SIGNATURE-----

--ivad277dvdv2q3fs--