From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mark Rutland <mark.rutland@arm.com>,
Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [patch 08/18] mm: Adjust system_state check
Date: Mon, 15 May 2017 08:18:26 +0200 [thread overview]
Message-ID: <20170515061826.GB30019@kroah.com> (raw)
In-Reply-To: <20170514183613.080486673@linutronix.de>
On Sun, May 14, 2017 at 08:27:24PM +0200, Thomas Gleixner wrote:
> To enable smp_processor_id() and might_sleep() debug checks earlier, it's
> required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.
>
> get_nid_for_pfn() checks for system_state == BOOTING to decide whether to
> use early_pfn_to_nid() when CONFIG_DEFERRED_STRUCT_PAGE_INIT=y.
>
> That check is dubious, because the switch to state RUNNING happes way after
> page_alloc_init_late() has been invoked.
>
> Change the check to less than RUNNING state so it covers the new
> intermediate states as well.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Mel Gorman <mgorman@techsingularity.net>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/base/node.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/base/node.c
> +++ b/drivers/base/node.c
> @@ -377,7 +377,7 @@ static int __ref get_nid_for_pfn(unsigne
> if (!pfn_valid_within(pfn))
> return -1;
> #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
> - if (system_state == SYSTEM_BOOTING)
> + if (system_state < SYSTEM_RUNNING)
Someone better comment the place where these are defined that they need
to be in a specific order, I don't think they have been tested this way
in the past...
With that change:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
thanks,
greg k-h
next prev parent reply other threads:[~2017-05-15 6:18 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-14 18:27 [patch 00/18] init: Enable might_sleep() and smp_processor_id() debugging early Thomas Gleixner
2017-05-14 18:27 ` [patch 01/18] init: Pin init task to boot cpu initially Thomas Gleixner
2017-05-15 14:10 ` Steven Rostedt
2017-05-14 18:27 ` [patch 02/18] arm: Adjust system_state check Thomas Gleixner
2017-05-14 18:27 ` [patch 03/18] arm64: " Thomas Gleixner
2017-05-14 18:27 ` [patch 04/18] x86/smp: " Thomas Gleixner
2017-05-15 14:17 ` Steven Rostedt
2017-05-14 18:27 ` [patch 05/18] metag: " Thomas Gleixner
2017-05-14 18:27 ` [patch 06/18] powerpc: " Thomas Gleixner
2017-05-15 9:19 ` Michael Ellerman
2017-05-14 18:27 ` [patch 07/18] ACPI: " Thomas Gleixner
2017-05-15 10:20 ` Mark Rutland
2017-05-15 10:25 ` Thomas Gleixner
2017-05-15 14:27 ` Steven Rostedt
2017-05-16 18:13 ` Thomas Gleixner
2017-05-14 18:27 ` [patch 08/18] mm: " Thomas Gleixner
2017-05-15 6:18 ` Greg Kroah-Hartman [this message]
2017-05-15 14:33 ` Steven Rostedt
2017-05-14 18:27 ` [patch 09/18] cpufreq/pasemi: " Thomas Gleixner
2017-05-15 5:24 ` Viresh Kumar
2017-05-15 14:34 ` Steven Rostedt
2017-05-14 18:27 ` [patch 10/18] iommu/vt-d: Adjust system_state checks Thomas Gleixner
2017-05-15 14:42 ` Joerg Roedel
2017-05-14 18:27 ` [patch 11/18] iommu/of: Adjust system_state check Thomas Gleixner
2017-05-15 10:45 ` Robin Murphy
2017-05-15 14:42 ` Joerg Roedel
2017-05-14 18:27 ` [patch 12/18] async: Adjust system_state checks Thomas Gleixner
2017-05-14 18:39 ` Arjan van de Ven
2017-05-14 18:27 ` [patch 13/18] extable: " Thomas Gleixner
2017-05-15 14:37 ` Steven Rostedt
2017-05-14 18:27 ` [patch 14/18] printk: " Thomas Gleixner
2017-05-15 14:53 ` Steven Rostedt
2017-05-14 18:27 ` [patch 15/18] mm/vmscan: " Thomas Gleixner
2017-05-15 14:54 ` Steven Rostedt
2017-05-14 18:27 ` [patch 16/18] init: Introduce SYSTEM_BOOTING_UP/SMP states Thomas Gleixner
2017-05-15 9:58 ` Juergen Gross
2017-05-15 14:58 ` Steven Rostedt
2017-05-14 18:27 ` [patch 17/18] sched: Enable might_sleep() checks early Thomas Gleixner
2017-05-15 15:10 ` Steven Rostedt
2017-05-15 19:12 ` Thomas Gleixner
2017-05-16 7:14 ` Peter Zijlstra
2017-05-16 7:33 ` Thomas Gleixner
2017-05-16 13:14 ` Steven Rostedt
2017-05-14 18:27 ` [patch 18/18] sched: Enable smp_processor_id() " Thomas Gleixner
2017-05-15 15:12 ` Steven Rostedt
2017-05-15 15:36 ` Thomas Gleixner
2017-05-15 11:53 ` [patch 00/18] init: Enable might_sleep() and smp_processor_id() debugging early Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515061826.GB30019@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).