From: Josh Zimmerman <joshz@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net,
Josh Zimmerman <joshz@google.com>
Subject: [PATCH v3] Add "shutdown" to "struct class".
Date: Mon, 15 May 2017 10:34:38 -0700 [thread overview]
Message-ID: <20170515173438.13420-1-joshz@google.com> (raw)
The TPM class has some common shutdown code that must be executed for
all drivers. This adds some needed functionality for that.
Usage example: 'tpm: Issue a TPM2_Shutdown for TPM2 devices.'
(see https://patchwork.kernel.org/patch/9724919/ for v2).
Signed-off-by: Josh Zimmerman <joshz@google.com>
-----
v2: Add Signed-off-by.
v3: Remove logically separate change.
---
drivers/base/core.c | 5 +++++
include/linux/device.h | 2 ++
2 files changed, 7 insertions(+)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index bbecaf9293be..5c1648875e94 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -2667,6 +2667,11 @@ void device_shutdown(void)
pm_runtime_get_noresume(dev);
pm_runtime_barrier(dev);
+ if (dev->class && dev->class->shutdown) {
+ if (initcall_debug)
+ dev_info(dev, "shutdown\n");
+ dev->class->shutdown(dev);
+ }
if (dev->bus && dev->bus->shutdown) {
if (initcall_debug)
dev_info(dev, "shutdown\n");
diff --git a/include/linux/device.h b/include/linux/device.h
index 9ef518af5515..f240baac2001 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -378,6 +378,7 @@ int subsys_virtual_register(struct bus_type *subsys,
* @suspend: Used to put the device to sleep mode, usually to a low power
* state.
* @resume: Used to bring the device from the sleep mode.
+ * @shutdown: Called at shut-down time to quiesce the device.
* @ns_type: Callbacks so sysfs can detemine namespaces.
* @namespace: Namespace of the device belongs to this class.
* @pm: The default device power management operations of this class.
@@ -407,6 +408,7 @@ struct class {
int (*suspend)(struct device *dev, pm_message_t state);
int (*resume)(struct device *dev);
+ int (*shutdown)(struct device *dev);
const struct kobj_ns_type_operations *ns_type;
const void *(*namespace)(struct device *dev);
--
2.13.0.rc2.291.g57267f2277-goog
next reply other threads:[~2017-05-15 17:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 17:34 Josh Zimmerman [this message]
2017-05-15 17:39 ` [PATCH v3] Add "shutdown" to "struct class" Josh Zimmerman
2017-05-15 17:45 ` Jason Gunthorpe
2017-05-15 20:49 ` Winkler, Tomas
2017-05-18 15:20 ` Josh Zimmerman
2017-05-25 13:09 ` Greg Kroah-Hartman
2017-05-25 15:40 ` Josh Zimmerman
2017-05-25 16:09 ` Greg Kroah-Hartman
2017-05-25 16:24 ` Josh Zimmerman
2017-05-25 16:41 ` Greg Kroah-Hartman
2017-05-25 22:40 ` Jarkko Sakkinen
2017-05-25 17:06 ` Jarkko Sakkinen
2017-05-25 17:05 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170515173438.13420-1-joshz@google.com \
--to=joshz@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).