From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752584AbdEPKx7 (ORCPT ); Tue, 16 May 2017 06:53:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:34575 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752531AbdEPKx4 (ORCPT ); Tue, 16 May 2017 06:53:56 -0400 Date: Tue, 16 May 2017 12:53:52 +0200 From: Michal Hocko To: Chris Wilson Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Daniel Vetter , Jani Nikula , Sean Paul , David Airlie Subject: Re: [PATCH] drm: use kvmalloc_array for drm_malloc* Message-ID: <20170516105352.GH2481@dhcp22.suse.cz> References: <20170516090606.5891-1-mhocko@kernel.org> <20170516093119.GW19912@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170516093119.GW19912@nuc-i3427.alporthouse.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 16-05-17 10:31:19, Chris Wilson wrote: > On Tue, May 16, 2017 at 11:06:06AM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > drm_malloc* has grown their own kmalloc with vmalloc fallback > > implementations. MM has grown kvmalloc* helpers in the meantime. Let's > > use those because it a) reduces the code and b) MM has a better idea > > how to implement fallbacks (e.g. do not vmalloc before kmalloc is tried > > with __GFP_NORETRY). > > Better? The same idea. The only difference I was reluctant to hand out > large pages for long lived objects. If that's the wisdom of the core mm, > so be it. vmalloc tends to fragment physical memory more os it is preferable to try the physically contiguous request first and only fall back to vmalloc if the first attempt would be too costly or it fails. > Reviewed-by: Chris Wilson thanks! -- Michal Hocko SUSE Labs