linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mel Gorman <mgorman@techsingularity.net>
Subject: [patch V2 08/17] mm: Adjust system_state check
Date: Tue, 16 May 2017 20:42:39 +0200	[thread overview]
Message-ID: <20170516184735.528279534@linutronix.de> (raw)
In-Reply-To: 20170516184231.564888231@linutronix.de

[-- Attachment #1: mm--Adjust-system_state-check.patch --]
[-- Type: text/plain, Size: 1079 bytes --]

To enable smp_processor_id() and might_sleep() debug checks earlier, it's
required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING.

get_nid_for_pfn() checks for system_state == BOOTING to decide whether to
use early_pfn_to_nid() when CONFIG_DEFERRED_STRUCT_PAGE_INIT=y.

That check is dubious, because the switch to state RUNNING happes way after
page_alloc_init_late() has been invoked.

Change the check to less than RUNNING state so it covers the new
intermediate states as well.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mel Gorman <mgorman@techsingularity.net>
---
 drivers/base/node.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -377,7 +377,7 @@ static int __ref get_nid_for_pfn(unsigne
 	if (!pfn_valid_within(pfn))
 		return -1;
 #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
-	if (system_state == SYSTEM_BOOTING)
+	if (system_state < SYSTEM_RUNNING)
 		return early_pfn_to_nid(pfn);
 #endif
 	page = pfn_to_page(pfn);

  parent reply	other threads:[~2017-05-16 18:52 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16 18:42 [patch V2 00/17] init: Enable might_sleep() and smp_processor_id() debugging early Thomas Gleixner
2017-05-16 18:42 ` [patch V2 01/17] init: Pin init task to boot cpu initially Thomas Gleixner
2017-05-16 19:06   ` Steven Rostedt
2017-05-23  8:47   ` [tip:sched/core] init: Pin init task to the boot CPU, initially tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 02/17] arm: Adjust system_state check Thomas Gleixner
2017-05-23  8:48   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 03/17] arm64: " Thomas Gleixner
2017-05-17 10:09   ` Mark Rutland
2017-05-17 14:23   ` Catalin Marinas
2017-05-23  8:48   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 04/17] x86/smp: " Thomas Gleixner
2017-05-23  8:49   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 05/17] metag: " Thomas Gleixner
2017-05-23  8:50   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 06/17] powerpc: " Thomas Gleixner
2017-05-23  8:50   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 07/17] ACPI: " Thomas Gleixner
2017-05-16 19:07   ` Steven Rostedt
2017-05-23  8:51   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` Thomas Gleixner [this message]
2017-05-23  8:51   ` [tip:sched/core] mm: " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 09/17] cpufreq/pasemi: " Thomas Gleixner
2017-05-23  8:52   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 10/17] iommu/vt-d: Adjust system_state checks Thomas Gleixner
2017-05-23  8:52   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 11/17] iommu/of: Adjust system_state check Thomas Gleixner
2017-05-23  8:53   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 12/17] async: Adjust system_state checks Thomas Gleixner
2017-05-23  8:53   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 13/17] extable: " Thomas Gleixner
2017-05-23  8:54   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 14/17] printk: " Thomas Gleixner
2017-05-23  8:55   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 15/17] mm/vmscan: " Thomas Gleixner
2017-05-17  6:56   ` Vlastimil Babka
2017-05-23  8:55   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 16/17] init: Introduce SYSTEM_SCHEDULING state Thomas Gleixner
2017-05-17 10:58   ` Mark Rutland
2017-05-17 21:15   ` Boris Ostrovsky
2017-05-23  8:56   ` [tip:sched/core] " tip-bot for Thomas Gleixner
2017-05-16 18:42 ` [patch V2 17/17] sched: Enable might_sleep() and smp_processor_id() checks early Thomas Gleixner
2017-05-16 19:12   ` Steven Rostedt
2017-05-16 22:46     ` Thomas Gleixner
2017-05-16 22:50       ` Steven Rostedt
2017-05-17 11:02   ` Mark Rutland
2017-05-23  8:56   ` [tip:sched/core] sched/core: " tip-bot for Thomas Gleixner
2017-05-17 10:58 ` [patch V2 00/17] init: Enable might_sleep() and smp_processor_id() debugging early Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170516184735.528279534@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).