From: Guenter Roeck <linux@roeck-us.net>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: kbuild test robot <lkp@intel.com>,
"kbuild-all@01.org" <kbuild-all@01.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing
Date: Tue, 16 May 2017 15:00:27 -0700 [thread overview]
Message-ID: <20170516220027.GA18668@roeck-us.net> (raw)
In-Reply-To: <247018ef273f4af9bedd77e63417daf0@svr-chch-ex1.atlnz.lc>
On Tue, May 16, 2017 at 08:30:52PM +0000, Chris Packham wrote:
> On 16/05/17 20:23, kbuild test robot wrote:
> > Hi Chris,
> >
> > [auto build test ERROR on hwmon/hwmon-next]
> > [also build test ERROR on v4.12-rc1 next-20170516]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> >
> > url: https://github.com/0day-ci/linux/commits/Chris-Packham/hwmon-adt7475-fan-stall-prevention/20170515-093530
> > base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
> > config: x86_64-rhel (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> > # save the attached .config to linux build tree
> > make ARCH=x86_64
> >
> > All errors (new ones prefixed by >>):
> >
> > drivers/hwmon/adt7475.c: In function 'set_temp_st':
> >>> drivers/hwmon/adt7475.c:622:9: error: implicit declaration of function 'find_closest_descending' [-Werror=implicit-function-declaration]
> > val = find_closest_descending(val, ad7475_st_map,
> > ^~~~~~~~~~~~~~~~~~~~~~~
> > cc1: some warnings being treated as errors
> >
> > vim +/find_closest_descending +622 drivers/hwmon/adt7475.c
> >
> > 616 shift = 4;
> > 617 idx = 1;
> > 618 break;
> > 619 }
> > 620
> > 621 if (val > 0) {
> > > 622 val = find_closest_descending(val, ad7475_st_map,
> > 623 ARRAY_SIZE(ad7475_st_map));
> > 624 val |= 0x8;
> > 625 }
> >
> > ---
> > 0-DAY kernel test infrastructure Open Source Technology Center
> > https://lists.01.org/pipermail/kbuild-all Intel Corporation
> >
>
> I'm not sure how this is failing. find_closest_descending() is a macro
> defined in linux/util_macros.h which is explicitly included in
> drivers/hwmon/adt7475.c. Aside from the include guards there's nothing
> conditional about it.
I suspect it was tested out of sequence, without the preceding patches,
and the header file include was missing.
Guenter
next prev parent reply other threads:[~2017-05-16 22:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170515013029.31397-1-chris.packham@alliedtelesis.co.nz>
2017-05-15 1:30 ` [PATCH v4 1/3] hwmon: (adt7475) fan stall prevention Chris Packham
2017-05-15 13:16 ` Guenter Roeck
2017-05-15 1:30 ` [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing Chris Packham
2017-05-15 13:18 ` Guenter Roeck
2017-05-16 8:17 ` kbuild test robot
2017-05-16 20:30 ` Chris Packham
2017-05-16 22:00 ` Guenter Roeck [this message]
2017-05-17 3:06 ` [kbuild-all] " Ye Xiaolong
2017-05-17 3:26 ` Chris Packham
2017-05-17 4:39 ` Ye Xiaolong
2017-05-17 5:24 ` Guenter Roeck
2017-05-18 3:05 ` Ye Xiaolong
2017-05-18 4:09 ` Guenter Roeck
2017-05-15 1:30 ` [PATCH v4 3/3] hwmon: (adt7475) add high frequency support Chris Packham
2017-05-15 13:26 ` Guenter Roeck
2017-05-15 21:02 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516220027.GA18668@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=kbuild-all@01.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).