From: Alberto Ladron <alberto.ladron@gmail.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, zaitcev@redhat.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: class: usblp: Fixed assignments inside if conditions
Date: Tue, 16 May 2017 19:37:31 -0500 [thread overview]
Message-ID: <20170517003731.GB7727@localhost.localdomain> (raw)
In-Reply-To: <201705161341.bzliJz8X%fengguang.wu@intel.com>
On Tue, May 16, 2017 at 01:44:47PM +0800, kbuild test robot wrote:
Hi,
Here is the fix. Or I have to resubmit the whole patch?
Signed-off-by: Alberto Ladron <alberto.ladron@gmail.com>
---
diff --git a/drivers/usb/class/usblp.c b/drivers/usb/class/usblp.c
index b1879ff..c335878 100644
--- a/drivers/usb/class/usblp.c
+++ b/drivers/usb/class/usblp.c
@@ -1018,7 +1018,7 @@ static int usblp_submit_read(struct usblp *usblp)
usblp->rcomplete = 0;
spin_unlock_irqrestore(&usblp->lock, flags);
rc = usb_submit_urb(urb, GFP_KERNEL);
- if (rv < 0) {
+ if (rc < 0) {
dev_dbg(&usblp->intf->dev, "error submitting urb (%d)\n", rc);
spin_lock_irqsave(&usblp->lock, flags);
usblp->rstatus = rc;
> Hi Alberto,
>
> [auto build test ERROR on usb/usb-testing]
> [also build test ERROR on v4.12-rc1 next-20170515]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Alberto-Ladron/usb-class-usblp-Fixed-assignments-inside-if-conditions/20170513-140010
> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> config: x86_64-rhel (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> drivers//usb/class/usblp.c: In function 'usblp_submit_read':
> >> drivers//usb/class/usblp.c:1021:6: error: 'rv' undeclared (first use in this function)
> if (rv < 0) {
> ^~
> drivers//usb/class/usblp.c:1021:6: note: each undeclared identifier is reported only once for each function it appears in
>
> vim +/rv +1021 drivers//usb/class/usblp.c
>
> 1005 urb = usb_alloc_urb(0, GFP_KERNEL);
> 1006 if (urb == NULL)
> 1007 goto raise_urb;
> 1008
> 1009 usb_fill_bulk_urb(urb, usblp->dev,
> 1010 usb_rcvbulkpipe(usblp->dev,
> 1011 usblp->protocol[usblp->current_protocol].epread->bEndpointAddress),
> 1012 usblp->readbuf, USBLP_BUF_SIZE_IN,
> 1013 usblp_bulk_read, usblp);
> 1014 usb_anchor_urb(urb, &usblp->urbs);
> 1015
> 1016 spin_lock_irqsave(&usblp->lock, flags);
> 1017 usblp->readcount = 0; /* XXX Why here? */
> 1018 usblp->rcomplete = 0;
> 1019 spin_unlock_irqrestore(&usblp->lock, flags);
> 1020 rc = usb_submit_urb(urb, GFP_KERNEL);
> > 1021 if (rv < 0) {
> 1022 dev_dbg(&usblp->intf->dev, "error submitting urb (%d)\n", rc);
> 1023 spin_lock_irqsave(&usblp->lock, flags);
> 1024 usblp->rstatus = rc;
> 1025 usblp->rcomplete = 1;
> 1026 spin_unlock_irqrestore(&usblp->lock, flags);
> 1027 goto raise_submit;
> 1028 }
> 1029
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2017-05-17 5:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 5:50 [PATCH] usb: class: usblp: Fixed assignments inside if conditions Alberto Ladron
2017-05-16 5:44 ` kbuild test robot
2017-05-17 0:37 ` Alberto Ladron [this message]
2017-05-17 8:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170517003731.GB7727@localhost.localdomain \
--to=alberto.ladron@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).