From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754041AbdEQKmD (ORCPT ); Wed, 17 May 2017 06:42:03 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48174 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751782AbdEQKmA (ORCPT ); Wed, 17 May 2017 06:42:00 -0400 Date: Wed, 17 May 2017 12:41:50 +0200 From: Heiko Carstens To: Tobias Klauser Cc: Martin Schwidefsky , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] s390: use generic fb.h References: <20170517083449.1994-1-tklauser@distanz.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170517083449.1994-1-tklauser@distanz.ch> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 17051710-0008-0000-0000-0000044AEC72 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17051710-0009-0000-0000-00001DB67447 Message-Id: <20170517104150.GB6131@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-17_09:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705170083 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 17, 2017 at 10:34:49AM +0200, Tobias Klauser wrote: > The arch uses a verbatim copy of the asm-generic version and does not > add any own implemntations to the header, so use asm-generic/fb.h > instead of duplicating code. > > Signed-off-by: Tobias Klauser > --- > arch/s390/include/asm/Kbuild | 1 + > arch/s390/include/asm/fb.h | 12 ------------ > 2 files changed, 1 insertion(+), 12 deletions(-) > delete mode 100644 arch/s390/include/asm/fb.h Thanks, however a similar patch which addresses this and yet another header file is available in our features branch, which should be part of linux-next soon: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h=features&id=b14b748a1df95a91207ba34981c9a51061b8c93d