From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753578AbdEQKqY (ORCPT <rfc822;w@1wt.eu>);
        Wed, 17 May 2017 06:46:24 -0400
Received: from foss.arm.com ([217.140.101.70]:45780 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751680AbdEQKqV (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 17 May 2017 06:46:21 -0400
Date: Wed, 17 May 2017 11:45:44 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: Jan Glauber <jglauber@cavium.com>
Cc: Will Deacon <will.deacon@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Borislav Petkov <bp@alien8.de>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: Re: [PATCH v5 1/3] perf: export perf_event_update_userpage()
Message-ID: <20170517104544.GE14654@leverpostej>
References: <20170517083122.5050-1-jglauber@cavium.com>
 <20170517083122.5050-2-jglauber@cavium.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170517083122.5050-2-jglauber@cavium.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jan,

On Wed, May 17, 2017 at 10:31:20AM +0200, Jan Glauber wrote:
> Export perf_event_update_userpage() to make it usable from a module.
> 
> Signed-off-by: Jan Glauber <jglauber@cavium.com>

Please make sure to Cc the relevant maintainers, e.g. those listed by:

	get_maintainer.pl -f kernel/events/core.c

... I've added them this time.

It would be nice for the commit message to state that this is the only
thing blocking building some system PMU drivers as modules.

Otherwise, this looks sane to me.

Thanks,
Mark.

> ---
>  kernel/events/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 6e75a5c..6578b9f 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -4933,6 +4933,7 @@ void perf_event_update_userpage(struct perf_event *event)
>  unlock:
>  	rcu_read_unlock();
>  }
> +EXPORT_SYMBOL_GPL(perf_event_update_userpage);
>  
>  static int perf_mmap_fault(struct vm_fault *vmf)
>  {
> -- 
> 2.9.0.rc0.21.g7777322
>