From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754872AbdERHnd (ORCPT ); Thu, 18 May 2017 03:43:33 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:51458 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752823AbdERHn3 (ORCPT ); Thu, 18 May 2017 03:43:29 -0400 Date: Thu, 18 May 2017 10:42:59 +0300 From: Dan Carpenter To: Kishon Vijay Abraham I , Yendapally Reddy Dhananjaya Reddy Cc: Vivek Gautam , Krzysztof Kozlowski , Yoshihiro Shimoda , Florian Fainelli , Axel Lin , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] phy: phy-brcm-sata: Fix a loop timeout Message-ID: <20170518074258.ywzdmtuxjxykabs2@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We expect to timeout with "try" set to zero but it's a post-op so actually it ends with it set to -1. I've fixed this by changing it to a pre-op. Fixes: 024812889ad1 ("phy: Add SATA3 PHY support for Broadcom NSP SoC") Signed-off-by: Dan Carpenter diff --git a/drivers/phy/broadcom/phy-brcm-sata.c b/drivers/phy/broadcom/phy-brcm-sata.c index ccbc3d994998..48fb016ce689 100644 --- a/drivers/phy/broadcom/phy-brcm-sata.c +++ b/drivers/phy/broadcom/phy-brcm-sata.c @@ -329,7 +329,7 @@ static int brcm_nsp_sata_init(struct brcm_sata_port *port) /* Wait for pll_seq_done bit */ try = 50; - while (try--) { + while (--try) { val = brcm_sata_phy_rd(base, BLOCK0_REG_BANK, BLOCK0_XGXSSTATUS); if (val & BLOCK0_XGXSSTATUS_PLL_LOCK)