From: Christoph Hellwig <hch@infradead.org>
To: Gabriele Paoloni <gabriele.paoloni@huawei.com>
Cc: bhelgaas@google.com, helgaas@kernel.org, linuxarm@huawei.com,
linux-pci@vger.kernel.org, lukas@wunner.de,
linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com,
hch@infradead.org, liudongdong3@huawei.com
Subject: Re: [PATCH v2 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services
Date: Thu, 18 May 2017 02:26:30 -0700 [thread overview]
Message-ID: <20170518092630.GA28006@infradead.org> (raw)
In-Reply-To: <1495098098-1984-2-git-send-email-gabriele.paoloni@huawei.com>
> - * pcie_port_enable_msix - try to set up MSI-X as interrupt mode for given port
> + * pcie_port_enable_msix_or_msi - try to set up MSI-X or MSI as interrupt mode
> + * for given port
just rename it to pcie_port_enable_vecs to avoid the overly long line..
> + * pci_irq_vector() below is able to handle entry differently
> + * depending on MSI vs MSI-x case
As mentioned in the review for the other patch: no need to repeat
this for every user of pci_irq_vector.
Otherwise this looks fine to me:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2017-05-18 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 9:01 [PATCH v2 0/2] add MSI support for PCIe port services and DPC IRQ support Gabriele Paoloni
2017-05-18 9:01 ` [PATCH v2 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services Gabriele Paoloni
2017-05-18 9:26 ` Christoph Hellwig [this message]
2017-05-18 10:08 ` Gabriele Paoloni
2017-05-18 9:01 ` [PATCH v2 2/2] PCI/portdrv: allocate MSI/MSIx vector for DPC RP service Gabriele Paoloni
2017-05-18 9:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518092630.GA28006@infradead.org \
--to=hch@infradead.org \
--cc=bhelgaas@google.com \
--cc=gabriele.paoloni@huawei.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).