From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933772AbdERRyS (ORCPT <rfc822;w@1wt.eu>);
        Thu, 18 May 2017 13:54:18 -0400
Received: from gateway23.websitewelcome.com ([192.185.50.161]:13307 "EHLO
        gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S933400AbdERRyR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 18 May 2017 13:54:17 -0400
Date: Thu, 18 May 2017 12:54:13 -0500
Message-ID: <20170518125413.Horde.xnD_6K5mFzkhQLdyz7R3LXt@gator4166.hostgator.com>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: "Saleem, Shiraz" <shiraz.saleem@intel.com>
Cc: "Latif, Faisal" <faisal.latif@intel.com>,
        Doug Ledford <dledford@redhat.com>,
        "Hefty, Sean" <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [infiniband-hw-i40iw] question about identical code for
 different branches
References: <20170517170654.Horde.cfktFjC4G4wPJvJ8X1ZyUvW@gator4166.hostgator.com>
 <9DD61F30A802C4429A01CA4200E302A730338947@fmsmsx116.amr.corp.intel.com>
In-Reply-To: <9DD61F30A802C4429A01CA4200E302A730338947@fmsmsx116.amr.corp.intel.com>
User-Agent: Horde Application Framework 5
Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes
MIME-Version: 1.0
Content-Disposition: inline
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - gator4166.hostgator.com
X-AntiAbuse: Original Domain - vger.kernel.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - embeddedor.com
X-BWhitelist: no
X-Source-IP: 108.167.133.22
X-Exim-ID: 1dBPcr-0007Sm-3m
X-Source: 
X-Source-Args: 
X-Source-Dir: 
X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:46935
X-Source-Auth: garsilva@embeddedor.com
X-Email-Count: 9
X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Quoting "Saleem, Shiraz" <shiraz.saleem@intel.com>:

>> Subject: [infiniband-hw-i40iw] question about identical code for  
>> different branches
>>
>>
>> index f4d1368..48fd327 100644
>> --- a/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
>> +++ b/drivers/infiniband/hw/i40iw/i40iw_virtchnl.c
>> @@ -443,10 +443,7 @@ enum i40iw_status_code i40iw_vchnl_recv_pf(struct
>> i40iw_sc_dev *dev,
>>          if (!dev->vchnl_up)
>>                  return I40IW_ERR_NOT_READY;
>>          if (vchnl_msg->iw_op_code == I40IW_VCHNL_OP_GET_VER) {
>> -               if (vchnl_msg->iw_op_ver != I40IW_VCHNL_OP_GET_VER_V0)
>> -                       vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
>> -               else
>> -                       vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
>> +               vchnl_pf_send_get_ver_resp(dev, vf_id, vchnl_msg);
>>                  return I40IW_SUCCESS;
>>          }
>>          for (iw_vf_idx = 0; iw_vf_idx < I40IW_MAX_PE_ENABLED_VF_COUNT;
>> iw_vf_idx++) {
>>
>> What do you think?
>>
>> I'd really appreciate any comment on this.
>>
> Yes. This fix is fine.
>

I'll send a patch in a full and proper format shortly.

Thank you all for your comments.
--
Gustavo A. R. Silva