From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755274AbdERNkN (ORCPT ); Thu, 18 May 2017 09:40:13 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55280 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752968AbdERNkK (ORCPT ); Thu, 18 May 2017 09:40:10 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A3704600B9 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v3,1/2] mwifiex: initiate card-specific work atomically From: Kalle Valo In-Reply-To: <20170501193700.89264-1-briannorris@chromium.org> References: <20170501193700.89264-1-briannorris@chromium.org> To: Brian Norris Cc: Ganapathi Bhat , Nishant Sarmukadam , , Dmitry Torokhov , linux-wireless@vger.kernel.org, Brian Norris User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20170518134009.8E38F60F5F@smtp.codeaurora.org> Date: Thu, 18 May 2017 13:40:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Brian Norris wrote: > The non-atomic test + set is a little awkward here, and it technically > means we might double-schedule work unnecessarily. AFAICT, this is not > really a problem, since the extra "work" will be a no-op (the flag(s) > will be cleared by then), but it's still an anti-pattern. > > Rewrite this to use the atomic test_and_set_bit() helper instead. > > Signed-off-by: Brian Norris > Reviewed-by: Dmitry Torokhov 2 patches applied to wireless-drivers-next.git, thanks. 21f569af9ab3 mwifiex: initiate card-specific work atomically 6d7d579a8243 mwifiex: pcie: add card_reset() support -- https://patchwork.kernel.org/patch/9706851/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches