From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932460AbdESURq (ORCPT ); Fri, 19 May 2017 16:17:46 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:41230 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756083AbdESURk (ORCPT ); Fri, 19 May 2017 16:17:40 -0400 Date: Fri, 19 May 2017 23:16:41 +0300 From: Dan Carpenter To: Eric Anholt Cc: Jani Nikula , Colin King , Tom Cooksey , David Airlie , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static Message-ID: <20170519201641.fwnoakx5gew7wo5t@mwanda> References: <20170519110203.19417-1-colin.king@canonical.com> <874lwhoxyk.fsf@intel.com> <20170519194759.gfiefx6xwrnrjn3x@mwanda> <874lwg8v9n.fsf@eliezer.anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874lwg8v9n.fsf@eliezer.anholt.net> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 19, 2017 at 01:08:20PM -0700, Eric Anholt wrote: > OK, that's definitely not how I've read the > Documentation/process/submitting-patches.rst description of the Fixes > tag, which talks about bugs found with git bisect and things that should > go to -stable. I would not have considered what this patch is changing > to be a bug. True. I don't consider this a bug either. I wouldn't have included a Fixes tag. I pretty much agree with the submitting-patches.rst except it should probably say to include it on more stuff. Fixes: tags are required for all bugfixes to netdev for example. regards, dan carpenter