From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762945AbdEVX05 (ORCPT ); Mon, 22 May 2017 19:26:57 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57120 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759952AbdEVX04 (ORCPT ); Mon, 22 May 2017 19:26:56 -0400 Date: Mon, 22 May 2017 19:26:51 -0400 (EDT) Message-Id: <20170522.192651.252662920166760334.davem@davemloft.net> To: ast@fb.com Cc: peterz@infradead.org, bgregg@netflix.com, daniel@iogearbox.net, qinteng@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH net-next 2/2] samples/bpf: add samples for HW_CACHE / RAW events From: David Miller In-Reply-To: <20170522224840.810121-3-ast@fb.com> References: <20170522224840.810121-1-ast@fb.com> <20170522224840.810121-3-ast@fb.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 May 2017 15:45:22 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexei Starovoitov Date: Mon, 22 May 2017 15:48:40 -0700 > @@ -31,7 +31,7 @@ static unsigned long long (*bpf_get_current_uid_gid)(void) = > (void *) BPF_FUNC_get_current_uid_gid; > static int (*bpf_get_current_comm)(void *buf, int buf_size) = > (void *) BPF_FUNC_get_current_comm; > -static int (*bpf_perf_event_read)(void *map, int index) = > +static u64 (*bpf_perf_event_read)(void *map, u64 flags) = > (void *) BPF_FUNC_perf_event_read; If the second argument really is "u64 flags", then please update the comments in tools/include/uapi/linux/bpf.h as well. Thank you.