From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763234AbdEVXku (ORCPT ); Mon, 22 May 2017 19:40:50 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:57246 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760212AbdEVXkt (ORCPT ); Mon, 22 May 2017 19:40:49 -0400 Date: Mon, 22 May 2017 19:40:41 -0400 (EDT) Message-Id: <20170522.194041.936213399075786231.davem@davemloft.net> To: ast@fb.com Cc: peterz@infradead.org, bgregg@netflix.com, daniel@iogearbox.net, qinteng@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH net-next 2/2] samples/bpf: add samples for HW_CACHE / RAW events From: David Miller In-Reply-To: <63c0ec55-9cb7-50a0-2020-fe17283e532b@fb.com> References: <20170522224840.810121-3-ast@fb.com> <20170522.192651.252662920166760334.davem@davemloft.net> <63c0ec55-9cb7-50a0-2020-fe17283e532b@fb.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 22 May 2017 15:59:10 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexei Starovoitov Date: Mon, 22 May 2017 16:35:07 -0700 > yet perf_event_read() is least documented. hmm. > * u64 bpf_perf_event_read(&map, index) > * Return: Number events read or error code > > that needs to be fixed. That's exactly what I was talking about :-)