Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Mario.Limonciello@dell.com
Cc: gregkh@linuxfoundation.org, andreas.noever@gmail.com,
	michael.jamet@intel.com, yehezkel.bernat@intel.com,
	lukas@wunner.de, amir.jer.levy@intel.com, luto@kernel.org,
	Jared.Dominguez@dell.com, andriy.shevchenko@linux.intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade
Date: Mon, 22 May 2017 14:37:09 +0300	[thread overview]
Message-ID: <20170522113709.GX8541@lahna.fi.intel.com> (raw)
In-Reply-To: <20170520082412.GI8541@lahna.fi.intel.com>

On Sat, May 20, 2017 at 11:24:12AM +0300, Mika Westerberg wrote:
> On Fri, May 19, 2017 at 05:54:37PM +0000, Mario.Limonciello@dell.com wrote:
> > > 
> > > It happens occasionally when you reboot the machine when a device is
> > > connected but seems to be dependent on the BIOS version. Since it is the
> > > BIOS who is supposed to enumerated these devices, I suspect that it is
> > > either problem in BIOS or our PCI enumeration code does something wrong.
> > > 
> > 
> > I'm fairly certain it's an issue somewhere with Linux PCI enumeration.  I took 
> > the exact same HW and switched it out the SSD to one w/ Win10 1607.
> > I set the dock and cable to "always allow" in TBT settings applet.
> > 
> > I don't reproduce any problems with enumeration with the dock plugged in
> > on cold boot.  All the devices hanging off the bridge show up properly.
> 
> You mean in Windows you don't reproduce the problem, right? Even when
> you reboot the machine with devices connected.
> 
> I tried on Intel Skull Canyon NUC so that I disabled the thunderbolt
> driver and after reboot (warm) I can see the PCI scan error about bus
> being partially hidden behind a bridge.
> 
> When this happens PCIe ports of the thunderbolt device/host seem to be
> unconfigured and Linux then decides to reconfigure them which leads to
> the problem. When it works we get ACPI hotplug event to the PCIe root
> port and the PCIe upstream/downstream ports are properly configured by
> the BIOS.
> 
> I guess Windows does something differently here than what we do when PCI
> devices are enumerated.

We discussed this with our BIOS/firmware people and there was a firmware
bug that caused many issues around hotplug and reboot flows. Is is
possible for you to try with the latest BIOS and see if the issue
reproduces (or are you already running the latest)?