From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932915AbdEVXVJ (ORCPT ); Mon, 22 May 2017 19:21:09 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:33567 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762893AbdEVXVE (ORCPT ); Mon, 22 May 2017 19:21:04 -0400 From: Matthias Kaehlcke To: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson , Andrew Morton , Matthias Kaehlcke Subject: [PATCH] x86/ioapic: Remove unused function IO_APIC_irq_trigger() Date: Mon, 22 May 2017 16:20:35 -0700 Message-Id: <20170522232035.187985-1-mka@chromium.org> X-Mailer: git-send-email 2.13.0.303.g4ebf302169-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function isn't used since commit 5ad274d41c1b ("x86/irq: Remove unused old IOAPIC irqdomain interfaces"). Removing it fixes the following warning when building with clang: arch/x86/kernel/apic/io_apic.c:1219:19: error: unused function 'IO_APIC_irq_trigger' [-Werror,-Wunused-function] Signed-off-by: Matthias Kaehlcke --- Andrew, this is a practical example of clangs 'unused-function' warning on static inline functions being useful. arch/x86/kernel/apic/io_apic.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c index 347bb9f65737..247880fc29f9 100644 --- a/arch/x86/kernel/apic/io_apic.c +++ b/arch/x86/kernel/apic/io_apic.c @@ -1200,28 +1200,6 @@ EXPORT_SYMBOL(IO_APIC_get_PCI_irq_vector); static struct irq_chip ioapic_chip, ioapic_ir_chip; -#ifdef CONFIG_X86_32 -static inline int IO_APIC_irq_trigger(int irq) -{ - int apic, idx, pin; - - for_each_ioapic_pin(apic, pin) { - idx = find_irq_entry(apic, pin, mp_INT); - if ((idx != -1) && (irq == pin_2_irq(idx, apic, pin, 0))) - return irq_trigger(idx); - } - /* - * nonexistent IRQs are edge default - */ - return 0; -} -#else -static inline int IO_APIC_irq_trigger(int irq) -{ - return 1; -} -#endif - static void __init setup_IO_APIC_irqs(void) { unsigned int ioapic, pin; -- 2.13.0.303.g4ebf302169-goog