From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965678AbdEWDCh (ORCPT ); Mon, 22 May 2017 23:02:37 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:33241 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933122AbdEWDCe (ORCPT ); Mon, 22 May 2017 23:02:34 -0400 From: Tahsin Erdogan To: "Theodore Ts'o" , Andreas Dilger Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Tahsin Erdogan Subject: [PATCH] ext4: fix quota charging for shared xattr blocks Date: Mon, 22 May 2017 20:01:48 -0700 Message-Id: <20170523030148.24361-1-tahsin@google.com> X-Mailer: git-send-email 2.13.0.219.gdb65acc882-goog Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ext4_xattr_block_set() calls dquot_alloc_block() to charge for an xattr block when new references are made. However if dquot_initialize() hasn't been called on an inode, request for charging is effectively ignored because ext4_inode_info->i_dquot is not initialized yet. Add dquot_initialize() call to ext4_xattr_set_handle(). Signed-off-by: Tahsin Erdogan --- fs/ext4/xattr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 8fb7ce14e6eb..e94575448550 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1166,6 +1166,11 @@ ext4_xattr_set_handle(handle_t *handle, struct inode *inode, int name_index, return -EINVAL; if (strlen(name) > 255) return -ERANGE; + + error = dquot_initialize(inode); + if (error) + return error; + ext4_write_lock_xattr(inode, &no_expand); error = ext4_reserve_inode_write(handle, inode, &is.iloc); -- 2.13.0.219.gdb65acc882-goog