From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761588AbdEWGjQ (ORCPT ); Tue, 23 May 2017 02:39:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:60898 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757375AbdEWGjO (ORCPT ); Tue, 23 May 2017 02:39:14 -0400 Date: Tue, 23 May 2017 08:39:11 +0200 From: Michal Hocko To: Wei Yang Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] refine and rename slub sysfs Message-ID: <20170523063911.GC12813@dhcp22.suse.cz> References: <20170517141146.11063-1-richard.weiyang@gmail.com> <20170518090636.GA25471@dhcp22.suse.cz> <20170523032705.GA4275@WeideMBP.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170523032705.GA4275@WeideMBP.lan> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 23-05-17 11:27:05, Wei Yang wrote: > On Thu, May 18, 2017 at 11:06:37AM +0200, Michal Hocko wrote: > >On Wed 17-05-17 22:11:40, Wei Yang wrote: > >> This patch serial could be divided into two parts. > >> > >> First three patches refine and adds slab sysfs. > >> Second three patches rename slab sysfs. > >> > >> 1. Refine slab sysfs > >> > >> There are four level slabs: > >> > >> CPU > >> CPU_PARTIAL > >> PARTIAL > >> FULL > >> > >> And in sysfs, it use show_slab_objects() and cpu_partial_slabs_show() to > >> reflect the statistics. > >> > >> In patch 2, it splits some function in show_slab_objects() which makes sure > >> only cpu_partial_slabs_show() covers statistics for CPU_PARTIAL slabs. > >> > >> After doing so, it would be more clear that show_slab_objects() has totally 9 > >> statistic combinations for three level of slabs. Each slab has three cases > >> statistic. > >> > >> slabs > >> objects > >> total_objects > >> > >> And when we look at current implementation, some of them are missing. So patch > >> 2 & 3 add them up. > >> > >> 2. Rename sysfs > >> > >> The slab statistics in sysfs are > >> > >> slabs > >> objects > >> total_objects > >> cpu_slabs > >> partial > >> partial_objects > >> cpu_partial_slabs > >> > >> which is a little bit hard for users to understand. The second three patches > >> rename sysfs file in this pattern. > >> > >> xxx_slabs[[_total]_objects] > >> > >> Finally it looks Like > >> > >> slabs > >> slabs_objects > >> slabs_total_objects > >> cpu_slabs > >> cpu_slabs_objects > >> cpu_slabs_total_objects > >> partial_slabs > >> partial_slabs_objects > >> partial_slabs_total_objects > >> cpu_partial_slabs > > > >_Why_ do we need all this? > > To have a clear statistics for each slab level. Is this worth risking breakage of the userspace which consume this data now? Do you have any user space code which will greatly benefit from the new data and which couldn't do the same with the current format/output? If yes this all should be in the changelog. -- Michal Hocko SUSE Labs