From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761209AbdEWHCa (ORCPT ); Tue, 23 May 2017 03:02:30 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:58343 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752938AbdEWHC3 (ORCPT ); Tue, 23 May 2017 03:02:29 -0400 Date: Tue, 23 May 2017 00:02:27 -0700 From: Christoph Hellwig To: Andrew Morton Cc: Anshuman Khandual , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Define KB, MB, GB, TB in core VM Message-ID: <20170523070227.GA27864@infradead.org> References: <20170522111742.29433-1-khandual@linux.vnet.ibm.com> <20170522141149.9ef84bb0713769f4af0383f0@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170522141149.9ef84bb0713769f4af0383f0@linux-foundation.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2017 at 02:11:49PM -0700, Andrew Morton wrote: > On Mon, 22 May 2017 16:47:42 +0530 Anshuman Khandual wrote: > > > There are many places where we define size either left shifting integers > > or multiplying 1024s without any generic definition to fall back on. But > > there are couples of (powerpc and lz4) attempts to define these standard > > memory sizes. Lets move these definitions to core VM to make sure that > > all new usage come from these definitions eventually standardizing it > > across all places. > > Grep further - there are many more definitions and some may now > generate warnings. > > Newly including mm.h for these things seems a bit heavyweight. I can't > immediately think of a more appropriate place. Maybe printk.h or > kernel.h. IFF we do these kernel.h is the right place. And please also add the MiB & co variants for the binary versions right next to the decimal ones.