From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966197AbdEWHS3 (ORCPT ); Tue, 23 May 2017 03:18:29 -0400 Received: from mail-wr0-f178.google.com ([209.85.128.178]:36012 "EHLO mail-wr0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936269AbdEWHSY (ORCPT ); Tue, 23 May 2017 03:18:24 -0400 Date: Tue, 23 May 2017 08:18:19 +0100 From: Lee Jones To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, Aaro Koskinen , Tony Lindgren , Russell King , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Alan Stern , Greg Kroah-Hartman , Felipe Balbi , Tomi Valkeinen , Bartlomiej Zolnierkiewicz , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 2/3] mfd: tps65010: move header file out of I2C realm Message-ID: <20170523071819.4zpdef7ofzz3moil@dell> References: <20170521220212.1404-1-wsa@the-dreams.de> <20170521220212.1404-3-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170521220212.1404-3-wsa@the-dreams.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 May 2017, Wolfram Sang wrote: > include/linux/i2c is not for client devices. Move the header file to a > more appropriate location. > > Signed-off-by: Wolfram Sang > --- > arch/arm/mach-omap1/board-h2-mmc.c | 2 +- > arch/arm/mach-omap1/board-h2.c | 2 +- > arch/arm/mach-omap1/board-h3-mmc.c | 2 +- > arch/arm/mach-omap1/board-h3.c | 2 +- > arch/arm/mach-omap1/board-osk.c | 2 +- > arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 2 +- > arch/arm/mach-s3c24xx/mach-osiris.c | 2 +- > drivers/mfd/tps65010.c | 2 +- For my own reference: Acked-for-MFD-by: Lee Jones > drivers/usb/host/ohci-omap.c | 2 +- > drivers/usb/phy/phy-isp1301-omap.c | 2 +- > drivers/video/fbdev/omap/lcd_h3.c | 2 +- > include/linux/{i2c => mfd}/tps65010.h | 2 +- > 12 files changed, 12 insertions(+), 12 deletions(-) > rename include/linux/{i2c => mfd}/tps65010.h (99%) > > diff --git a/arch/arm/mach-omap1/board-h2-mmc.c b/arch/arm/mach-omap1/board-h2-mmc.c > index 357be2debc9da8..91bda9c802ff38 100644 > --- a/arch/arm/mach-omap1/board-h2-mmc.c > +++ b/arch/arm/mach-omap1/board-h2-mmc.c > @@ -14,7 +14,7 @@ > #include > #include > #include > -#include > +#include > > #include "board-h2.h" > #include "mmc.h" > diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c > index 675254ee4b1e93..dece47d76282ac 100644 > --- a/arch/arm/mach-omap1/board-h2.c > +++ b/arch/arm/mach-omap1/board-h2.c > @@ -28,7 +28,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > diff --git a/arch/arm/mach-omap1/board-h3-mmc.c b/arch/arm/mach-omap1/board-h3-mmc.c > index 4f58bfa5e7549e..692c267a9a9052 100644 > --- a/arch/arm/mach-omap1/board-h3-mmc.c > +++ b/arch/arm/mach-omap1/board-h3-mmc.c > @@ -14,7 +14,7 @@ > #include > #include > > -#include > +#include > > #include "common.h" > #include "board-h3.h" > diff --git a/arch/arm/mach-omap1/board-h3.c b/arch/arm/mach-omap1/board-h3.c > index e62f9d454f1005..6d32beeb2d8857 100644 > --- a/arch/arm/mach-omap1/board-h3.c > +++ b/arch/arm/mach-omap1/board-h3.c > @@ -28,7 +28,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > #include > diff --git a/arch/arm/mach-omap1/board-osk.c b/arch/arm/mach-omap1/board-osk.c > index 4dfb995048103b..f20361b8ffb6e0 100644 > --- a/arch/arm/mach-omap1/board-osk.c > +++ b/arch/arm/mach-omap1/board-osk.c > @@ -38,7 +38,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > > diff --git a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c > index 262ab07447483a..6cac7da15e2b0d 100644 > --- a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c > +++ b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c > @@ -17,7 +17,7 @@ > #include > #include > > -#include > +#include > > #include > #include > diff --git a/arch/arm/mach-s3c24xx/mach-osiris.c b/arch/arm/mach-s3c24xx/mach-osiris.c > index 70b0eb7d31347f..64b1a0b7b803a1 100644 > --- a/arch/arm/mach-s3c24xx/mach-osiris.c > +++ b/arch/arm/mach-s3c24xx/mach-osiris.c > @@ -24,7 +24,7 @@ > #include > #include > > -#include > +#include > > #include > #include > diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c > index d829a6131f09e5..2ab67386b4ef1e 100644 > --- a/drivers/mfd/tps65010.c > +++ b/drivers/mfd/tps65010.c > @@ -32,7 +32,7 @@ > #include > #include > > -#include > +#include > > #include > > diff --git a/drivers/usb/host/ohci-omap.c b/drivers/usb/host/ohci-omap.c > index a4d814b7f38066..91393ec7d8503c 100644 > --- a/drivers/usb/host/ohci-omap.c > +++ b/drivers/usb/host/ohci-omap.c > @@ -53,7 +53,7 @@ > #define DRIVER_DESC "OHCI OMAP driver" > > #ifdef CONFIG_TPS65010 > -#include > +#include > #else > > #define LOW 0 > diff --git a/drivers/usb/phy/phy-isp1301-omap.c b/drivers/usb/phy/phy-isp1301-omap.c > index 042c5a8fd423d8..c6052c814bcc24 100644 > --- a/drivers/usb/phy/phy-isp1301-omap.c > +++ b/drivers/usb/phy/phy-isp1301-omap.c > @@ -96,7 +96,7 @@ struct isp1301 { > > #if IS_REACHABLE(CONFIG_TPS65010) > > -#include > +#include > > #else > > diff --git a/drivers/video/fbdev/omap/lcd_h3.c b/drivers/video/fbdev/omap/lcd_h3.c > index 9d2da146813ef0..796f4634c4c6f1 100644 > --- a/drivers/video/fbdev/omap/lcd_h3.c > +++ b/drivers/video/fbdev/omap/lcd_h3.c > @@ -21,7 +21,7 @@ > > #include > #include > -#include > +#include > #include > > #include "omapfb.h" > diff --git a/include/linux/i2c/tps65010.h b/include/linux/mfd/tps65010.h > similarity index 99% > rename from include/linux/i2c/tps65010.h > rename to include/linux/mfd/tps65010.h > index 08aa92278d71cd..a1fb9bc5311de4 100644 > --- a/include/linux/i2c/tps65010.h > +++ b/include/linux/mfd/tps65010.h > @@ -1,4 +1,4 @@ > -/* linux/i2c/tps65010.h > +/* linux/mfd/tps65010.h > * > * Functions to access TPS65010 power management device. > * -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog