From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
kernel-team@lge.com, Frederic Weisbecker <fweisbec@gmail.com>,
Milian Wolff <milian.wolff@kdab.com>
Subject: Re: [PATCH] perf tools: Fix to put caller above callee in children mode
Date: Tue, 23 May 2017 09:30:18 +0200 [thread overview]
Message-ID: <20170523073018.GA28417@krava> (raw)
In-Reply-To: <20170522125029.32525-1-namhyung@kernel.org>
On Mon, May 22, 2017 at 09:50:29PM +0900, Namhyung Kim wrote:
> The __hpp__sort_acc() sorts entries using callchain depth in order to
> put callers above in children mode. But it assumed the callchain order
> was callee-first. Now default (for children) is caller-first so the
> order of entries is reverted.
>
> For example, consider following case.
>
> $ perf report --no-children
> ..l
> # Overhead Command Shared Object Symbol
> # ........ ....... ................... ..........................
> #
> 99.44% a.out a.out [.] main
> |
> ---main
> __libc_start_main
> _start
>
> Then children mode should show 'start' above '__libc_start_main' since
> it's the caller (parent) of the __libc_start_main. But it's reversed:
>
> # Children Self Command Shared Object Symbol
> # ........ ........ ....... ............... .....................
> #
> 99.61% 0.00% a.out libc-2.25.so [.] __libc_start_main
> 99.61% 0.00% a.out a.out [.] _start
> 99.54% 99.44% a.out a.out [.] main
>
> This patch fixes it.
>
> # Children Self Command Shared Object Symbol
> # ........ ........ ....... ............... .....................
> #
> 99.61% 0.00% a.out a.out [.] _start
> 99.61% 0.00% a.out libc-2.25.so [.] __libc_start_main
> 99.54% 99.44% a.out a.out [.] main
>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Milian Wolff <milian.wolff@kdab.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
prev parent reply other threads:[~2017-05-23 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 12:50 [PATCH] perf tools: Fix to put caller above callee in children mode Namhyung Kim
2017-05-23 7:30 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523073018.GA28417@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).