From: Christoph Hellwig <hch@infradead.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] zlib: Put get_unaligned16() inside #ifdef block
Date: Tue, 23 May 2017 00:36:01 -0700 [thread overview]
Message-ID: <20170523073601.GA29525@infradead.org> (raw)
In-Reply-To: <20170522211326.66973-1-mka@chromium.org>
On Mon, May 22, 2017 at 02:13:26PM -0700, Matthias Kaehlcke wrote:
> The function is not used when CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS=y.
> Adding the #ifdef fixes the following warning when building with clang:
>
> lib/zlib_inflate/inffast.c:31:1: error: unused function 'get_unaligned16'
> [-Werror,-Wunused-function]
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> Note: Usually we would use the __maybe_unused attribute to silence the
> warning. Since this code is used in the kernel decompression stub rather
> than in the kernel itself we can't include <linux/compiler.h> with the
> definition of __maybe_unused (it would be possible for some platforms,
> however for powerpc the build fails with a compiler error). We could
> redefine __maybe_unused or use the raw __attribute__((unused)), but
> using the #ifdef is a simpler solution.
Usually one would take a look at the root cause. And then remove
get_unaligned16 entirely and replace it with the get_unaligned
helper provided by the kernel.
next prev parent reply other threads:[~2017-05-23 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 21:13 [PATCH] zlib: Put get_unaligned16() inside #ifdef block Matthias Kaehlcke
2017-05-22 21:39 ` Andrew Morton
2017-05-22 22:12 ` Matthias Kaehlcke
2017-05-23 7:36 ` Christoph Hellwig [this message]
2017-05-23 18:03 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523073601.GA29525@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).