From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966652AbdEWIUY (ORCPT ); Tue, 23 May 2017 04:20:24 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.172]:29130 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933221AbdEWIUU (ORCPT ); Tue, 23 May 2017 04:20:20 -0400 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrEIsWRWlGSWpSXmKPExsUSt3Opse7+D8q RBkvec1lcuXiIyWLqwydsFt+udDBZXN41h81i4tLVzBadu/pZLTZ8X8vowO6x4XMTm8fOWXfZ PTat6mTz2Pd2GZvHoV2OHuu3XGXx+LxJLoA9ijUzLym/IoE148Sqp+wFt9grJr9Ua2A8xdbFy MkhJLCeUeLnlzwIu0LizLVzjCA2m4CFxOQTD8BqWARUJb5cfQJkc3AICyRIfHyh1MXIxSEi0M UosfrVY3YQh1lgCaPE3dvXwZp5BRwk1j18zwphC0qcnPmEBcRmFpCQOPjiBTPEMgOJ0wsaweI SAvYS099fZQZZICGgL9F4LBYibCjxfdY3qBJziXvT9jFOYOSfhWTqLCRTFzAyrWLUKE4tKkst 0jU00UsqykzPKMlNzMzRNTQw1stNLS5OTE/NSUwq1kvOz93ECAxvBiDYwbhiu+chRkkOJiVR3 j0JypFCfEn5KZUZicUZ8UWlOanFhxhlODiUJHhV3gPlBItS01Mr0jJzgJEGk5bg4FES4RUESf MWFyTmFmemQ6ROMepyzLn39T2TEEtefl6qlDivHkiRAEhRRmke3AhY1F9ilJUS5mUEOkqIpyC 1KDezBFX+FaM4B6OSMG88yBSezLwSuE2vgI5gAjrC9S7YESWJCCmpBsZ195TEg84dNb5n2Ks0 Z+6OcpYZW9XcVzntlguKLPP5eMY+7n/0m49aFyzOJfvEdD6eZ6X6jrNTzfr+vS0vX9xdf/F6a uM5v6Unl2dYSM66Jr2Ig4l5n0ChmQTze7de25cBq/kcXeYpcbc+ad86V0tpgfVWLtapFXp3xd c4l590fVdpnHhpK6sSS3FGoqEWc1FxIgAyQyCf9QIAAA== X-Env-Sender: Adam.Thomson.Opensource@diasemi.com X-Msg-Ref: server-2.tower-39.messagelabs.com!1495527614!86297881!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 9.4.12; banners=-,-,- X-VirusChecked: Checked From: Adam Thomson Date: Tue, 23 May 2017 09:20:13 +0100 Subject: [RESEND PATCH] ASoC: da7218: Fix incorrect usage of bitwise '&' operator for SRM check To: Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai CC: Support Opensource , , , Takashi Sakamoto Message-ID: <20170523082013.981693FAD4@swsrvapps-01.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-ServerInfo: sw-ex-cashub01.diasemi.com, 9 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 23/05/2017 05:41:00 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the SRM lock check section of code the '&' bitwise operator is used as part of checking lock status. Functionally the code works as intended, but the conditional statement is a boolean comparison so should really use '&&' logical operator instead. This commit rectifies this discrepancy. Signed-off-by: Adam Thomson Reviewed-by: Takashi Sakamoto --- sound/soc/codecs/da7218.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/da7218.c b/sound/soc/codecs/da7218.c index d256ebf..6e1940e 100644 --- a/sound/soc/codecs/da7218.c +++ b/sound/soc/codecs/da7218.c @@ -1457,7 +1457,7 @@ static int da7218_dai_event(struct snd_soc_dapm_widget *w, ++i; msleep(DA7218_SRM_CHECK_DELAY); } - } while ((i < DA7218_SRM_CHECK_TRIES) & (!success)); + } while ((i < DA7218_SRM_CHECK_TRIES) && (!success)); if (!success) dev_warn(codec->dev, "SRM failed to lock\n"); -- 1.9.1