From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966875AbdEWIrV (ORCPT ); Tue, 23 May 2017 04:47:21 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:34824 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966865AbdEWIrO (ORCPT ); Tue, 23 May 2017 04:47:14 -0400 Date: Tue, 23 May 2017 09:47:05 +0100 From: Lee Jones To: Keerthy Cc: broonie@kernel.org, robh+dt@kernel.org, t-kristo@ti.com, tony@atomide.com, mark.rutland@arm.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 1/3] mfd: lp87565: Add lp87565 PMIC support Message-ID: <20170523084705.vfkqwdis6xxh7umd@dell> References: <1495197739-17446-1-git-send-email-j-keerthy@ti.com> <1495197739-17446-2-git-send-email-j-keerthy@ti.com> <20170522174806.nnpk5jso7jhgygm3@dell> <26169872-1b43-88d1-3e5b-367b4d446222@ti.com> <20170523065742.44ytkxdagw2wwttz@dell> <8e1d50d1-378b-aca5-a6f5-457a0bb1544a@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8e1d50d1-378b-aca5-a6f5-457a0bb1544a@ti.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 May 2017, Keerthy wrote: > On Tuesday 23 May 2017 01:11 PM, Keerthy wrote: > > On Tuesday 23 May 2017 12:27 PM, Lee Jones wrote: > >> On Tue, 23 May 2017, Keerthy wrote: > >>> On Monday 22 May 2017 11:18 PM, Lee Jones wrote: > >>>> On Fri, 19 May 2017, Keerthy wrote: > >>>> > >>>>> The LP87565 chip is a power management IC for Portable Navigation Systems > >>>>> and Tablet Computing devices. It contains the following components: > >>>>> > >>>>> - Configurable Bucks(Single and multi-phase). > >>>>> - Configurable General Purpose Output Signals (GPO). > >>>>> > >>>>> The LP87565-Q1 variant device uses two 2-phase outputs configuration, > >>>>> Buck0 is master for Buck0/1 output and Buck2 is master for Buck2/3 > >>>>> output. > >>>>> > >>>>> Signed-off-by: Keerthy > >>>>> --- > >>>>> Documentation/devicetree/bindings/mfd/lp87565.txt | 44 ++++ > >>>>> drivers/mfd/Kconfig | 14 ++ > >>>>> drivers/mfd/Makefile | 1 + > >>>>> drivers/mfd/lp87565.c | 103 ++++++++ > >>>>> include/linux/mfd/lp87565.h | 275 ++++++++++++++++++++++ > >>>>> 5 files changed, 437 insertions(+) > >>>>> create mode 100644 Documentation/devicetree/bindings/mfd/lp87565.txt > >>>>> create mode 100644 drivers/mfd/lp87565.c > >>>>> create mode 100644 include/linux/mfd/lp87565.h > >>>>> > >> > >> [...] > >> > >>>>> +/* > >>>>> + * Copyright (C) 2017 Texas Instruments Incorporated - http://www.ti.com/ > >>>>> + * > >>>>> + * Author: Keerthy > >>>> > >>>> We usually ask for full "first last" names. > >>> > >>> Keerthy is my full name and i do not have a surname. > >> > >> What is the 'J' for in your email address? > > > > Father's initials. > > https://lkml.org/lkml/2012/7/11/482 > > I have been using this for a while now. Right and Trump has been president for a while now, it doesn't mean it's okay. ;) > >> [...] > >> > >>>>> +static const struct i2c_device_id lp87565_id_table[] = { > >>>>> + { "lp87565-q1", 0 }, > >>>>> + { }, > >>>>> +}; > >>>>> +MODULE_DEVICE_TABLE(i2c, lp87565_id_table); > >>>> > >>>> Is this an OF only driver, or not? > >> > >> You didn't answer my question? > >> > > > > Sorry i replied on top again. It will be an OF only driver. > > > > Regards, > > Keerthy > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog