From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935659AbdEWLwt (ORCPT ); Tue, 23 May 2017 07:52:49 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:41107 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933847AbdEWLwq (ORCPT ); Tue, 23 May 2017 07:52:46 -0400 Date: Tue, 23 May 2017 13:52:17 +0200 From: Andrew Lunn To: Boris Brezillon Cc: Chris Packham , linux-mtd@lists.infradead.org, computersforpeace@gmail.com, dwmw2@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/5] mtd: mchp23k256: device tree and mchp23lcv1024 Message-ID: <20170523115217.GM13759@lunn.ch> References: <20170523004317.16908-1-chris.packham@alliedtelesis.co.nz> <20170523093957.24110476@bbrezillon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170523093957.24110476@bbrezillon> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 23, 2017 at 09:39:57AM +0200, Boris Brezillon wrote: > On Tue, 23 May 2017 12:43:12 +1200 > Chris Packham wrote: > > > This series adds device tree support to the mchp23k256 driver and > > support for the mchp23lcv1024 chip. I suspect there are more compatible > > variants that we could now enumerate if desired. > > > > Chris Packham (5): > > mtd: mchp23k256: Add OF device ID table > > mtd: mchp23k256: switch to mtd_device_register() > > mtd: handle partitioning on devices with 0 erasesize > > mtd: mchp23k256: add partitioning support > > mtd: mchp23k256: Add support for mchp23lcv1024 > > Shouldn't we add a spi_device_id table to allow non-DT users to probe > mchp23lcv1024 chips? Hi Boris This is something which can be added at any time. Currently there is no need for it, so i personally would wait until somebody does need it. Andrew