From: Pavel Machek <pavel@ucw.cz>
To: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-pm@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, rjw@rjwysocki.net,
len.brown@intel.com
Subject: Re: [PATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on AMD systems
Date: Tue, 23 May 2017 14:24:39 +0200 [thread overview]
Message-ID: <20170523122439.GA7483@amd> (raw)
In-Reply-To: <1495030819-4347-1-git-send-email-Yazen.Ghannam@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]
On Wed 2017-05-17 09:20:19, Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@amd.com>
>
> AMD systems support the Monitor/Mwait instructions and these can be used
> for ACPI C1 in the same way as on Intel systems, with appropriate BIOS
> support.
>
> Allow ffh_cstate_init() to succeed on AMD systems and make the Cstate
> description vendor-agnostic.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> ---
> arch/x86/kernel/acpi/cstate.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/acpi/cstate.c b/arch/x86/kernel/acpi/cstate.c
> index 8a908ae..4c5dd5d 100644
> --- a/arch/x86/kernel/acpi/cstate.c
> +++ b/arch/x86/kernel/acpi/cstate.c
> @@ -109,7 +109,7 @@ static long acpi_processor_ffh_cstate_probe_cpu(void *_cx)
> cx->type);
> }
> snprintf(cx->desc,
> - ACPI_CX_DESC_LEN, "ACPI FFH INTEL MWAIT 0x%x",
> + ACPI_CX_DESC_LEN, "ACPI FFH X86 MWAIT 0x%x",
> cx->address);
> out:
> return retval;
Are you sure no userspace depends on word "INTEL" there?
Does it make sense to include "X86" there?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-05-23 12:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 14:20 [PATCH] x86/ACPI/cstate: Allow ACPI C1 FFH MWAIT use on AMD systems Yazen Ghannam
2017-05-22 16:21 ` Borislav Petkov
2017-05-22 20:20 ` Ghannam, Yazen
2017-05-23 7:59 ` Borislav Petkov
2017-05-23 12:50 ` Ghannam, Yazen
2017-05-23 13:06 ` Borislav Petkov
2017-05-23 12:24 ` Pavel Machek [this message]
2017-05-24 18:16 ` Ghannam, Yazen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523122439.GA7483@amd \
--to=pavel@ucw.cz \
--cc=Yazen.Ghannam@amd.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).