From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966293AbdEWS7h (ORCPT ); Tue, 23 May 2017 14:59:37 -0400 Received: from mail-yb0-f182.google.com ([209.85.213.182]:35392 "EHLO mail-yb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764272AbdEWS7a (ORCPT ); Tue, 23 May 2017 14:59:30 -0400 Date: Tue, 23 May 2017 14:59:27 -0400 From: Tejun Heo To: Shaohua Li Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, Kernel-team@fb.com Subject: Re: [PATCH 5/5] kernfs: add exportfs operations Message-ID: <20170523185927.GC13222@htj.duckdns.org> References: <3d3a0860317afa0fb722c1a6df58e04593fc700a.1495490800.git.shli@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d3a0860317afa0fb722c1a6df58e04593fc700a.1495490800.git.shli@fb.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 22, 2017 at 03:53:09PM -0700, Shaohua Li wrote: > +static struct inode *kernfs_nfs_get_inode(struct super_block *sb, > + u64 ino, u32 generation) Heh, do we have to name this kernfs_nfs_get_inode()? I think it'd be nice to give it a different name and add a comment explaining the goal of the interface. Also, I think it probably would be better to make this an optional feature of kernfs. sysfs has no need to provide something like this yet. Thanks. -- tejun