From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Abel Vesa <abelvesa@gmail.com>
Cc: robin.murphy@arm.com, jjhiblot@traphandler.com,
nicstange@gmail.com, Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
pmladek@suse.com, mhiramat@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: ftrace: Adds support for CONFIG_DYNAMIC_FTRACE_WITH_REGS
Date: Tue, 23 May 2017 20:53:18 +0100 [thread overview]
Message-ID: <20170523195318.GC22219@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1494623207-17195-1-git-send-email-abelvesa@gmail.com>
On Fri, May 12, 2017 at 10:06:47PM +0100, Abel Vesa wrote:
> The DYNAMIC_FTRACE_WITH_REGS configuration makes it possible for a ftrace
> operation to specify if registers need to saved/restored by the ftrace handler.
> This is needed by kgraft and possibly other ftrace-based tools, and the ARM
> architecture is currently lacking this feature. It would also be the first step
> to support the "Kprobes-on-ftrace" optimization on ARM.
>
> This patch introduces a new ftrace handler that stores the registers on the
> stack before calling the next stage. The registers are restored from the stack
> before going back to the instrumented function.
>
> A side-effect of this patch is to activate the support for ftrace_modify_call()
> as it defines ARCH_SUPPORTS_FTRACE_OPS for the ARM architecture.
With the exception of the long lines in the commit message (please wrap
before column 72 so that 'git log' is readable on 80 column displays)
I think this is fine. Please amend the commit message and sent to the
patch system. Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-05-23 19:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-12 21:06 [PATCH] arm: ftrace: Adds support for CONFIG_DYNAMIC_FTRACE_WITH_REGS Abel Vesa
2017-05-23 19:53 ` Russell King - ARM Linux [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-05-12 20:38 abelvesa
2017-05-12 21:05 ` Abel Vesa
2016-12-08 22:49 Abel Vesa
2016-12-08 21:46 Abel Vesa
2016-12-08 22:46 ` Abel Vesa
2017-01-10 15:51 ` Petr Mladek
2017-01-12 0:19 ` Abel Vesa
2017-01-12 14:30 ` Jean-Jacques Hiblot
2017-01-13 8:30 ` Jean-Jacques Hiblot
2017-01-24 0:43 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523195318.GC22219@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=abelvesa@gmail.com \
--cc=jjhiblot@traphandler.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=nicstange@gmail.com \
--cc=pmladek@suse.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).